You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Bug description
It seems we have a problem with the rule ignoring classes not referenced, specifically the method: ruleClassNotReferencedRuleV1FalsePositive. When you mark a class reference as false positive, for instance, MyClassNonEmptyLeafUnused, that method is populated with an entry and we get something like this:
We could remove, of course, the introduced class ManifestRefactoringDataForTesting. But we would get back all the same errors we were getting without the Manifest.
What I will do is update the ReClassesHaveNoReferencesCondition>>violators method to discard those classes that are manifest. That would require implementing isManifest in RB-related classes.
Bug description
It seems we have a problem with the rule ignoring classes not referenced, specifically the method:
ruleClassNotReferencedRuleV1FalsePositive
. When you mark a class reference as false positive, for instance,MyClassNonEmptyLeafUnused
, that method is populated with an entry and we get something like this:We could remove, of course, the introduced class
ManifestRefactoringDataForTesting
. But we would get back all the same errors we were getting without the Manifest.What I will do is update the
ReClassesHaveNoReferencesCondition>>violators
method to discard those classes that are manifest. That would require implementingisManifest
in RB-related classes.To Reproduce
See PR #16917
The text was updated successfully, but these errors were encountered: