Cleanup: deprecate #notEmpty and use #isNotEmpty

Fix #14
pharo-contributions · Oct 26, 2023 · 3d0f7bd · 3d0f7bd
1 parent 8e6c146
commit 3d0f7bd
Show file tree

Hide file tree

Showing 9 changed files with 34 additions and 12 deletions.
diff --git a/src/XML-Writer-Core/XMLAttributeDeclarationWriter.class.st b/src/XML-Writer-Core/XMLAttributeDeclarationWriter.class.st
@@ -41,7 +41,7 @@ XMLAttributeDeclarationWriter >> defaultPragma [
 XMLAttributeDeclarationWriter >> defaultPragma: aDefaultPragma [
 
 	defaultPragma := (aDefaultPragma isNotNil and: [
-		                  aDefaultPragma notEmpty and: [
+		                  aDefaultPragma isNotEmpty and: [
 			                  aDefaultPragma first == $# ] ])
 		                 ifTrue: [ aDefaultPragma allButFirst ]
 		                 ifFalse: [ aDefaultPragma ]
@@ -105,7 +105,7 @@ XMLAttributeDeclarationWriter >> writeBody [
 { #category : #writing }
 XMLAttributeDeclarationWriter >> writeDefaultPragma [
 
-	self defaultPragma notEmpty ifTrue: [
+	self defaultPragma isNotEmpty ifTrue: [
 		self writer
 			space;
 			nextPut: $#;

diff --git a/src/XML-Writer-Core/XMLEntityDeclarationWriter.class.st b/src/XML-Writer-Core/XMLEntityDeclarationWriter.class.st
@@ -49,7 +49,7 @@ XMLEntityDeclarationWriter >> isParameter: aBoolean [
 { #category : #testing }
 XMLEntityDeclarationWriter >> isUnparsed [
 
-	^ self ndata notEmpty
+	^ self ndata isNotEmpty
 ]
 
 { #category : #accessing }

diff --git a/src/XML-Writer-Core/XMLExternalIDWriter.class.st b/src/XML-Writer-Core/XMLExternalIDWriter.class.st
@@ -14,13 +14,13 @@ Class {
 { #category : #testing }
 XMLExternalIDWriter >> hasPublicID [
 
-	^ self publicID notEmpty
+	^ self publicID isNotEmpty
 ]
 
 { #category : #testing }
 XMLExternalIDWriter >> hasSystemID [
 
-	^ self systemID notEmpty
+	^ self systemID isNotEmpty
 ]
 
 { #category : #testing }

diff --git a/src/XML-Writer-Core/XMLPIWriter.class.st b/src/XML-Writer-Core/XMLPIWriter.class.st
@@ -26,7 +26,7 @@ XMLPIWriter >> data: aString [
 { #category : #testing }
 XMLPIWriter >> hasData [
 
-	^ self data notEmpty
+	^ self data isNotEmpty
 ]
 
 { #category : #testing }

diff --git a/src/XML-Writer-Core/XMLTagWriter.class.st b/src/XML-Writer-Core/XMLTagWriter.class.st
@@ -57,13 +57,13 @@ XMLTagWriter >> attributes: anAssociationCollection [
 { #category : #testing }
 XMLTagWriter >> hasAttributes [
 
-	^ attributes isNotNil and: [ attributes notEmpty ]
+	^ attributes isNotNil and: [ attributes isNotEmpty ]
 ]
 
 { #category : #testing }
 XMLTagWriter >> hasXMLNSDeclarations [
 
-	^ xmlnsDeclarations isNotNil and: [ xmlnsDeclarations notEmpty ]
+	^ xmlnsDeclarations isNotNil and: [ xmlnsDeclarations isNotEmpty ]
 ]
 
 { #category : #testing }

diff --git a/src/XML-Writer-Core/XMLUnsafeStartTagWriter.class.st b/src/XML-Writer-Core/XMLUnsafeStartTagWriter.class.st
@@ -52,13 +52,13 @@ XMLUnsafeStartTagWriter >> attributes: anAssociationCollection [
 { #category : #testing }
 XMLUnsafeStartTagWriter >> hasAttributes [
 
-	^ attributes isNotNil and: [ attributes notEmpty ]
+	^ attributes isNotNil and: [ attributes isNotEmpty ]
 ]
 
 { #category : #testing }
 XMLUnsafeStartTagWriter >> hasXMLNSDeclarations [
 
-	^ xmlnsDeclarations isNotNil and: [ xmlnsDeclarations notEmpty ]
+	^ xmlnsDeclarations isNotNil and: [ xmlnsDeclarations isNotEmpty ]
 ]
 
 { #category : #testing }

diff --git a/src/XML-Writer-Core/XMLXMLDeclarationWriter.class.st b/src/XML-Writer-Core/XMLXMLDeclarationWriter.class.st
@@ -27,7 +27,7 @@ XMLXMLDeclarationWriter >> encoding: anEncoding [
 { #category : #testing }
 XMLXMLDeclarationWriter >> hasEncoding [
 
-	^ self encoding notEmpty
+	^ self encoding isNotEmpty
 ]
 
 { #category : #testing }

diff --git a/src/XML-Writer-Tests/ManifestXMLWriterTests.class.st b/src/XML-Writer-Tests/ManifestXMLWriterTests.class.st
@@ -0,0 +1,22 @@
+"
+Please describe the package using the class comment of the included manifest class. The manifest class also includes other additional metadata for the package. These meta data are used by other tools such as the SmalllintManifestChecker and the critics Browser
+"
+Class {
+	#name : #ManifestXMLWriterTests,
+	#superclass : #PackageManifest,
+	#category : #'XML-Writer-Tests-Manifest'
+}
+
+{ #category : #'code-critics' }
+ManifestXMLWriterTests class >> ruleDetectContainsRuleV1FalsePositive [
+
+	<ignoreForCoverage>
+	^ #(#(#(#RGMethodDefinition #(#XMLWriterRecordingFormatterProxy #receivedNextAll:with: #false)) #'2023-10-26T02:25:37.729304+02:00') )
+]
+
+{ #category : #'code-critics' }
+ManifestXMLWriterTests class >> ruleLiteralArrayContainsSuspiciousTrueFalseOrNilRuleV1FalsePositive [
+
+	<ignoreForCoverage>
+	^ #(#(#(#RGMetaclassDefinition #(#'ManifestXMLWriterTests class' #ManifestXMLWriterTests)) #'2023-10-26T02:26:03.499966+02:00') )
+]
diff --git a/src/XML-Writer-Tests/XMLWriterRecordingFormatterProxy.class.st b/src/XML-Writer-Tests/XMLWriterRecordingFormatterProxy.class.st
@@ -35,7 +35,7 @@ XMLWriterRecordingFormatterProxy >> receivedNextAll: aNameCollection with: anArg
 
 	aNameCollection do: [ :each |
 		| message |
-		(messageQueue notEmpty and: [
+		(messageQueue isNotEmpty and: [
 			 (message := messageQueue first) selector == each asSymbol and: [
 				 message arguments asArray = (Array with: anArgument) ] ])
 			ifFalse: [ ^ false ].