Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resfinder v4.5.0 #86

Merged
merged 2 commits into from
May 20, 2024
Merged

New Resfinder v4.5.0 #86

merged 2 commits into from
May 20, 2024

Conversation

DanyMatute
Copy link
Contributor

The newer version of Resfinder 4.5.0 produces NA and NA..NA when --inputfastq flag is implemented, and this flag is used to run the KMA. These are removed as it clashes with the expected variable type "int"

The newer version of Resfinder 4.5.0 produces NA and NA..NA when --inputfastq flag is implemented, and this flag is used to run the KMA. These are removed as it clashes with the expected variable type "int"
@fmaguire
Copy link
Member

Hi @DanyMatute this is great, thanks! Do you have a ResFinder v4.5 output on hand I can add as a testcase? No worries if not!

@fmaguire fmaguire merged commit 5852116 into pha4ge:master May 20, 2024
2 checks passed
@DanyMatute
Copy link
Contributor Author

DanyMatute commented May 20, 2024

Hello @fmaguire
here is a fastq resfinder 4.5.0 output
python3 -m resfinder --inputfastq read1.fastq read2.fastq --species species --disinfectant --acquired --point --ignore_missing_species --outputPath read_output ~{'--min_cov ' + min_cov} ~{'--threshold ' + threshold}

ResFinder_results_tab.txt

and a fasta resfinder 4.5.0 output
python3 -m resfinder --inputfasta assembly.fasta --species species --disinfectant --acquired --point --ignore_missing_species --outputPath assembly_output ~{'--min_cov ' + min_cov} ~{'--threshold ' + threshold}
ResFinder_results_tab.txt

finally a fasta and fastq resfinder 4.5.0 output
python3 -m resfinder --inputfasta assembly.fasta --inputfastq read1.fastq read2.fastq --species species --disinfectant --acquired --point --ignore_missing_species --outputPath assembly_output ~{'--min_cov ' + min_cov} ~{'--threshold ' + threshold}
ResFinder_results_tab.txt

@fmaguire
Copy link
Member

Amazing, I've just added some tests using your examples and will update the version shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants