fix annotation bug and make some beautifications #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemieuxl
reviewed
Jun 9, 2020
| @@ -636,7 +645,7 @@ def parse_args(): | |||
| comma | |||
| ``--significant-threshold`` Float The significant threshold for | |||
| linkage | |||
| ``--no-annotation`` Boolean Do not draw annotation (SNP names) | |||
| ``--no_annotation`` Boolean Do not draw annotation (SNP names) | |||
There was a problem hiding this comment.
Please stay with previous options, so that it doesn't change existing scripts (--no-annotation).
lemieuxl
reviewed
Jun 9, 2020
| @@ -482,7 +486,12 @@ def create_manhattan_plot(twopoint, multipoint, args): | |||
| else: | |||
| # There is some two-point data and annotation is asked, se we show | |||
| # the figure | |||
| plt.show() | |||
| plt.savefig(args.outFile_name + "." + args.graph_format, | |||
There was a problem hiding this comment.
This else is now irrelevant, since the same code is executed in both cases.
lemieuxl
reviewed
Jun 9, 2020
| @@ -893,7 +902,7 @@ def parse_args(): | |||
|
|
|||
| # The annotation flag | |||
| group.add_argument( | |||
| "--no-annotation", action="store_true", | |||
| "--no_annotation", action="store_true", | |||
There was a problem hiding this comment.
Same thing here, keep --no-annotation).
|
Thanks for the update. Just some small issue to verify. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix annotation bug and make some beautification