Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced pgAdmin 4 with support for Workspace layouts. #7708 #8245

Closed
wants to merge 1 commit into from

Conversation

akshay-joshi
Copy link
Contributor

No description provided.

@akshay-joshi akshay-joshi force-pushed the side_workspace branch 2 times, most recently from 9427e93 to 5574bad Compare December 9, 2024 07:09
Copy link
Contributor

@adityatoshniwal adityatoshniwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on eyeball review.

web/pgadmin/browser/server_groups/servers/__init__.py Outdated Show resolved Hide resolved
web/pgadmin/misc/__init__.py Outdated Show resolved Hide resolved
web/pgadmin/static/js/BrowserComponent.jsx Outdated Show resolved Hide resolved
web/pgadmin/static/js/BrowserComponent.jsx Outdated Show resolved Hide resolved
web/pgadmin/static/js/BrowserComponent.jsx Outdated Show resolved Hide resolved
web/pgadmin/static/js/UtilityView.jsx Outdated Show resolved Hide resolved
web/pgadmin/static/js/UtilityView.jsx Outdated Show resolved Hide resolved
web/pgadmin/static/js/UtilityView.jsx Outdated Show resolved Hide resolved
@akshay-joshi akshay-joshi force-pushed the side_workspace branch 2 times, most recently from 3a8a033 to 8bc2276 Compare December 10, 2024 08:47
Added adhoc connection support

1) Disable menu for other workspace.
2) Compare server name as well while adding the adhoc server.
3) PSQL tool should shown error if binary path is not set.

Added logic to disconnect from all the servers, when layout is changed.

1) Disabled Schema Diff workspace if no tabs are present.
2) Make code generic.

Fixed Demo comments.

Fixed Javascript test cases

Fixed feature test.

Updated documentation.

Fixed review comments.
@akshay-joshi
Copy link
Contributor Author

Closing this PR and will create a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants