feat: Add options at the publish level of the gps sender #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 31, 2023 14:15
…tamp and modify documentation GpsSenderOptionsStamp
jon-ht
reviewed
Aug 6, 2023
| $this->pubSubClient | ||
| ->topic($this->gpsConfiguration->getTopicName()) | ||
| ->publish($messageBuilder->build()) | ||
| ->publish($messageBuilder->build(), $options) |
There was a problem hiding this comment.
$options might be undefined if GpsSenderOptionsStamp is not in the envelope
There was a problem hiding this comment.
yes, please put the $options = [] before the if statement or put here $options ?? []
marforon
requested changes
Aug 23, 2023
| $this->pubSubClient | ||
| ->topic($this->gpsConfiguration->getTopicName()) | ||
| ->publish($messageBuilder->build()) | ||
| ->publish($messageBuilder->build(), $options) |
There was a problem hiding this comment.
yes, please put the $options = [] before the if statement or put here $options ?? []
| /** | ||
| * @param array<string, mixed> $options | ||
| */ | ||
| public function __construct(array $options) { |
There was a problem hiding this comment.
Please, put it on a new line. https://www.php-fig.org/psr/psr-12/#44-methods-and-functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to add options to the publish method of google pub/sub on the GpsSender
I added a specific stamp for this.
I propose it in the need on a project to use this in addition to the orderingKey :
gps->publish(messageBuilder->build, ["enableMessageOrdering" => true]);