This repository has been archived by the owner on Jun 16, 2023. It is now read-only.
ADD: Remove roles when user remove reaction #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the role of the user when the reaction is removed.
bastianleicht
approved these changes
Jun 11, 2021
peterthehan
reviewed
Jun 13, 2021
| * @returns {Promise<void>} | ||
| */ | ||
| module.exports = async (messageReaction, user) => { | ||
| const manager = new ReactionRoleManager(messageReaction, user); |
There was a problem hiding this comment.
can we add a new config setting to enable/disable this behavior, maybe something like removeRolesOnReactionRemove
the line immediately following creating the manager can call something like:
Suggested change
| const manager = new ReactionRoleManager(messageReaction, user); | |
| const manager = new ReactionRoleManager(messageReaction, user); | |
| if (!manager.handleRolesOnReactionRemove()) { | |
| return; | |
| } |
README will also have to update, instruction text can be something like:
removeRolesOnReactionRemovedetermines whether a user's previously assigned roles are removed when the user removes their reaction (true) or not (false). Note thatremoveReactionmust befalsefor this to work properly.
There was a problem hiding this comment.
copy paste for your convenience
- `removeRolesOnReactionRemove` determines whether a user's previously assigned roles are removed when the user removes their reaction (`true`) or not (`false`). Note that `removeReaction` must be `false` for this to work properly.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the role of the user when the reaction is removed.