Skip to content

Commit

Permalink
Really enable assembly signing for release builds
Browse files Browse the repository at this point in the history
  • Loading branch information
peteroupc committed May 30, 2017
1 parent aae3f1a commit 17d5ca9
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 6 deletions.
7 changes: 6 additions & 1 deletion CBOR.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,13 @@
<AssemblyName>CBOR</AssemblyName>
<DefaultLanguage>en-US</DefaultLanguage>
<FileAlignment>512</FileAlignment>
<ProjectTypeGuids>{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}</ProjectTypeGuids>
<ProjectTypeGuids>{786C830F-07A1-408B-BD7F-6EE04809D6DB};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}</ProjectTypeGuids>
<NoWin32Manifest>False</NoWin32Manifest>
<NuGetPackageImportStamp>
</NuGetPackageImportStamp>
<AssemblyOriginatorKeyFile>PeterO.snk</AssemblyOriginatorKeyFile>
<TargetFrameworkVersion>v4.5</TargetFrameworkVersion>
<TargetFrameworkProfile>Profile259</TargetFrameworkProfile>
</PropertyGroup>
<PropertyGroup Condition=" '$(Platform)' == 'AnyCPU' ">
<PlatformTarget>AnyCPU</PlatformTarget>
Expand Down Expand Up @@ -62,10 +65,12 @@
<CodeAnalysisRuleSet>CBOR.ruleset</CodeAnalysisRuleSet>
<DebugType>none</DebugType>
<DebugSymbols>false</DebugSymbols>
<SignAssembly>true</SignAssembly>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'ReleaseNet40|AnyCPU'">
<DocumentationFile>bin\ReleaseNet40\CBOR.xml</DocumentationFile>
<CodeAnalysisRuleSet>CBOR.ruleset</CodeAnalysisRuleSet>
<SignAssembly>true</SignAssembly>
</PropertyGroup>
<ItemGroup>
<Compile Include="PeterO\BigInteger.cs" />
Expand Down
6 changes: 3 additions & 3 deletions CBOR.nuspec
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<package>
<metadata>
<id>PeterO.Cbor</id>
<version>2.5</version>
<version>2.5.1</version>
<title>CBOR</title>
<authors>Peter Occil</authors>
<owners>Peter Occil</owners>
Expand All @@ -15,8 +15,8 @@
</description>
<summary>A C# implementation of Concise Binary Object Representation (CBOR), a data serialization format. This implementation can also convert between CBOR and JSON.</summary>
<releaseNotes>
In version 2.5:
* Sign the CBOR assembly with a strong name key
In version 2.5.1:
* Really sign the CBOR assembly with a strong name key
In version 2.4.2:
* Really use 0.2.2 of
[`PeterO.Numbers`](https://www.nuget.org/packages/PeterO.Numbers)
Expand Down
2 changes: 1 addition & 1 deletion Properties/AssemblyInfo.cs
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,4 @@ Any copyright is dedicated to the Public Domain.
//
// You can specify all the values or you can use the default the Revision and
// Build Numbers by using the '*' as shown below:
[assembly: AssemblyVersion("2.5")]
[assembly: AssemblyVersion("2.5.1")]
7 changes: 6 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -233,9 +233,14 @@ The following are some clarifications to RFC 7049.
Release Notes
-----------

### Version 2.5.1

* Really sign the CBOR assembly with a strong name key.

### Version 2.5

* Sign the CBOR assembly with a strong name key
* Sign the CBOR assembly with a strong name key (UPDATE: Version 2.5 was
mistakenly released without a strong name.)
* Update [`PeterO.Numbers`](https://www.nuget.org/packages/PeterO.Numbers) to
strong-named version

Expand Down

0 comments on commit 17d5ca9

Please sign in to comment.