Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Date validation is resulting in false negatives and positives for some people born on Feb-29 on a leap year. For example,
200002292399
is incorrectly failing validation:Related issue
Replaces #46
Motivation
Allow people born on leap years to use services relying on this package 🙈
Checklist
PS. I would like to add the
200002292399
SSN to the list of test data here: https://github.com/personnummer/meta/blob/master/testdata/list.jsonHowever, when running the
generateTestdata.php
script it's generating different SSNs and I'm not sure how is your contribution flow for those test. I could use some help adding it. 😅