Mobile: Accessibility: Improve tags screen accessibility

This commit:
1. Migrates tags.js to TypeScript.
2. Adds role and hint information to tag items.

Note: See https://github.com/formidablelabs/eslint-plugin-react-native-a11y/blob/master/docs/rules/has-accessibility-hint.md for examples of how to use accessibilityHint.

.eslintignore

@@ -766,6 +766,7 @@ packages/app-mobile/components/screens/UpgradeSyncTargetScreen.js
 packages/app-mobile/components/screens/dropbox-login.js
 packages/app-mobile/components/screens/encryption-config.js
 packages/app-mobile/components/screens/status.js
+packages/app-mobile/components/screens/tags.js
 packages/app-mobile/components/side-menu-content.js
 packages/app-mobile/components/testing/TestProviderStack.js
 packages/app-mobile/components/voiceTyping/VoiceTypingDialog.js

.gitignore

@@ -742,6 +742,7 @@ packages/app-mobile/components/screens/UpgradeSyncTargetScreen.js
 packages/app-mobile/components/screens/dropbox-login.js
 packages/app-mobile/components/screens/encryption-config.js
 packages/app-mobile/components/screens/status.js
+packages/app-mobile/components/screens/tags.js
 packages/app-mobile/components/side-menu-content.js
 packages/app-mobile/components/testing/TestProviderStack.js
 packages/app-mobile/components/voiceTyping/VoiceTypingDialog.js

packages/app-mobile/components/screens/tags.tsx

@@ -0,0 +1,100 @@
+import * as React from 'react';
+
+import { View, Text, FlatList, StyleSheet, TouchableOpacity } from 'react-native';
+import { connect } from 'react-redux';
+import Tag from '@joplin/lib/models/Tag';
+import { themeStyle } from '../global-style';
+import { ScreenHeader } from '../ScreenHeader';
+import { _ } from '@joplin/lib/locale';
+import { AppState } from '../../utils/types';
+import { TagEntity } from '@joplin/lib/services/database/types';
+import { useCallback, useMemo, useState } from 'react';
+import { Dispatch } from 'redux';
+import useAsyncEffect from '@joplin/lib/hooks/useAsyncEffect';
+
+interface Props {
+	dispatch: Dispatch;
+	themeId: number;
+}
+
+const useStyles = (themeId: number) => {
+	return useMemo(() => {
+		const theme = themeStyle(themeId);
+
+		return StyleSheet.create({
+			listItem: {
+				flexDirection: 'row',
+				borderBottomWidth: 1,
+				borderBottomColor: theme.dividerColor,
+				alignItems: 'flex-start',
+				paddingLeft: theme.marginLeft,
+				paddingRight: theme.marginRight,
+				paddingTop: theme.itemMarginTop,
+				paddingBottom: theme.itemMarginBottom,
+			},
+			listItemText: {
+				flex: 1,
+				color: theme.color,
+				fontSize: theme.fontSize,
+			},
+			rootStyle: theme.rootStyle,
+		});
+	}, [themeId]);
+};
+
+
+const TagsScreenComponent: React.FC<Props> = props => {
+	const [tags, setTags] = useState<TagEntity[]>([]);
+	const styles = useStyles(props.themeId);
+
+	type TagItemPressEvent = { id: string };
+
+	useAsyncEffect(async () => {
+		const tags = await Tag.allWithNotes();
+		tags.sort((a, b) => {
+			return a.title.toLowerCase() < b.title.toLowerCase() ? -1 : +1;
+		});
+		setTags(tags);
+	}, []);
+
+	const onTagItemPress = useCallback((event: TagItemPressEvent) => {
+		props.dispatch({ type: 'SIDE_MENU_CLOSE' });
+
+		props.dispatch({
+			type: 'NAV_GO',
+			routeName: 'Notes',
+			tagId: event.id,
+		});
+	}, [props.dispatch]);
+
+	type RenderItemEvent = { item: TagEntity };
+	const onRenderItem = useCallback(({ item }: RenderItemEvent) => {
+		return (
+			<TouchableOpacity
+				onPress={() => onTagItemPress({ id: item.id })}
+				accessibilityRole='button'
+				accessibilityHint={_('Navigates to notes for tags')}
+			>
+				<View style={styles.listItem}>
+					<Text style={styles.listItemText}>{item.title}</Text>
+				</View>
+			</TouchableOpacity>
+		);
+	}, [onTagItemPress, styles]);
+
+	return (
+		<View style={styles.rootStyle}>
+			<ScreenHeader title={_('Tags')} showSearchButton={false} />
+			<FlatList style={{ flex: 1 }} data={tags} renderItem={onRenderItem} keyExtractor={tag => tag.id} />
+		</View>
+	);
+};
+
+
+const TagsScreen = connect((state: AppState) => {
+	return {
+		themeId: state.settings.theme,
+	};
+})(TagsScreenComponent);
+
+export default TagsScreen;

packages/app-mobile/root.tsx

@@ -56,7 +56,7 @@ import RevisionService from '@joplin/lib/services/RevisionService';
 import JoplinDatabase from '@joplin/lib/JoplinDatabase';
 import Database from '@joplin/lib/database';
 import NotesScreen from './components/screens/Notes';
-const { TagsScreen } = require('./components/screens/tags.js');
+import TagsScreen from './components/screens/tags';
 import ConfigScreen from './components/screens/ConfigScreen/ConfigScreen';
 const { FolderScreen } = require('./components/screens/folder.js');
 import LogScreen from './components/screens/LogScreen';