Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for LIMIT case insensitive #445

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dveeden
Copy link
Collaborator

@dveeden dveeden commented Sep 19, 2024

The test was testing for LIMIT and limit but didn't work for Limit etc.

Follow up for #349

@kebhr @mohawk2 what do you think about this?

I think strncasecmp may not be available on Windows, so this might need an ifdef with a Windows specific solution (_strnicmp()).

@mohawk2
Copy link
Contributor

mohawk2 commented Sep 21, 2024

I think you're right that it should be case-insensitive! And my quick googling shows there is indeed a #ifdef needed on Windows.

@kebhr
Copy link
Contributor

kebhr commented Sep 21, 2024

I also agree to this change. It will follow the MySQL specification more closely and do not believe that this change will cause a degrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants