Make statistics_info use catalog arg

[mohawk2]

Sorry for taking two goes at this. It was bothering me today that I saw the catalog info coming back from the db, but I knew statistics_info had filtering on that disabled. Now it's not (with a test, and everything!).

[dveeden]

As MySQL doesn't support catalogs, the name it returns is always def isn't it? Does it make sense to do filtering on that?

mysql-9.0.1> SELECT CATALOG_NAME FROM information_schema.schemata GROUP BY CATALOG_NAME;
+--------------+
| CATALOG_NAME |
+--------------+
| def          |
+--------------+
1 row in set (0.01 sec)

I know that there are plans to add catalog support to MariaDB, but that hasn't been merged yet.

• https://mariadb.com/kb/en/catalogs-overview/
• https://jira.mariadb.org/browse/MDEV-31542

[mohawk2]

It seems to me that in that case this addition is harmless, and if someone uses this DBD for MariaDB (which I've heard of as a thing) after it gets catalogs, this addition would become valuable?

[mohawk2]

By the way, your AppVeyor config looks broken - it's giving an error talking about not finding project files?

[dveeden]

By the way, your AppVeyor config looks broken - it's giving an error talking about not finding project files?

Yes, this is a known issue. See also:

• Setup CI job for Windows and MySQL 8.x #359
• Try new appveyor.yml #384

Basically AppVeyor didn't have MySQL 8.x (it now does) but the Strawberry Perl is still build with MySQL 5.7.x client libraries, which are too old for DBD::mysql. I would still like to get this working again to be able to test on windows.