Added CRONTRIBUTING file #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prklm10
approved these changes
Apr 30, 2024
prklm10
reviewed
Apr 30, 2024
CRONTRIBUTING.md
Outdated
| @@ -0,0 +1,103 @@ | |||
| # Contributing to @percy/agent | |||
There was a problem hiding this comment.
Need to change the name to @percy/storybook
prklm10
reviewed
Apr 30, 2024
|
|
||
| If possible, make [atomic commits](https://en.wikipedia.org/wiki/Atomic_commit), which means: | ||
| - a commit should contain exactly one self-contained functional change | ||
| - a functional change should be contained in exactly one commit |
There was a problem hiding this comment.
Both line means the same thing right?
There was a problem hiding this comment.
Yes, thats how atomic commits are described in wikipedia article. A -> B and B -> A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added contributing file so that open source contributors have some guidelines while creating PRs