✨ add fetching env support for storybook v7+ #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilshah98
changed the title
nilshah98
requested review from
prklm10 and
shantanuk-browserstack
and removed request for
a team
nilshah98
added a commit
that referenced
this pull request
Oct 27, 2023
* feat: uncache stories before extracting them (#828) * ✨ add fetching env support for storybook v7+ (#827) * feat: add fetching env support for storybook v7+ * chore: lint using --fix * fix: evalStorybookEnvironmentInfo * feat: update package.json and lockfile for storybook v7 * fix: convert start-storybook to storybook dev * fix: add framework option to storybook config * feat: update babel and package config to node 16 * feat: update github actions to use node 16 * chore: lint fix * feat: add storybook-v6 to support start-storybook and build-storybook binaries * wip: use storybook 6 as default * fix: make storybook6 default, and keep storybook7 separate * fix: inherit stdio to run tests * fix: support storybook6 tests * wip: add flag support for switching between storybook v6 <> v7 tests * fix: build storybook command in pretest * wip: add utils and support for storybook v7 tests only * test: fix case where storybook had not loaded yet for live url testing * wip: run storybook6 tests by default * fix: change babel build target version to 14 * feat: add storybook v6 and v7 test workflows, also remove default test workflow * feat: downgrade node 16 to node 14 in github workflows and package json engine * feat: upgrade node 14 to 16 for lint and release workflows, since they run yarn in their workflows * chore: update yarn.lock as per storybook v7, node 16 * fix: pin action sha, use inputs.branch and use yarn test in v6 * fix: check if error exists before checking for message attribute * docs: add and update `Development` section in readme * chore: add EOF
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.