Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Skip story on error and move to next stories #819

Merged
merged 3 commits into from
Oct 13, 2023
Merged

✨ Skip story on error and move to next stories #819

merged 3 commits into from
Oct 13, 2023

Conversation

ninadbstack
Copy link
Contributor

@ninadbstack ninadbstack commented Oct 12, 2023 •
edited
Loading

Context:

  • Currently if percySnapshot fails on one of the stories [ say dom.js returned an exception or timedout ] we throw that error again
  • This breaks test suite and no further stories are uploaded

Change:

  • We add an env var PERCY_SKIP_STORY_ON_ERROR which if set to 'true' would log the error skip the story and move to next story
  • We also recreate the page to avoid any state related issues

@ninadbstack ninadbstack marked this pull request as ready for review October 13, 2023 11:02
@ninadbstack ninadbstack requested a review from a team as a code owner October 13, 2023 11:02
itsjwala
itsjwala reviewed Oct 13, 2023
View reviewed changes
Copy link
Contributor

@itsjwala itsjwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ninadbstack ninadbstack merged commit 7b02234 into master Oct 13, 2023
4 checks passed
@ninadbstack ninadbstack deleted the skip-story-on-error branch October 13, 2023 11:34
@ninadbstack ninadbstack added the ✨ enhancement New feature or request label Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsjwala itsjwala itsjwala approved these changes

@prklm10 prklm10 Awaiting requested review from prklm10 prklm10 is a code owner automatically assigned from percy/percy-product-reviewers

Assignees
No one assigned
Labels
✨ enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ninadbstack @itsjwala