Add @percy/sdk-utils dependency #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
samarsault
commented
Oct 3, 2023
•
samarsault
commented
- @percy/sdk-utils is used but not present in the list of dependencies
- Since it gets resolved from @percy/cli automatically, it has not been an issue. CLI is expected to be present
- With CLI binary and Browserstack SDK however, this expectation changes. CLI is not present as a separate dependency
- Hence, to include this in SDK, we'll have to add a separate dependency for this.
- But it's better added here, so we can include a single one there
ninadbstack
approved these changes
Oct 3, 2023
itsjwala
reviewed
Oct 3, 2023
samarsault
force-pushed
the
sdk-utils-deps
branch
from
85c866e to
a5eea46
Compare
itsjwala
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.