Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix, additional full page options is not working #355

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Conversation

prklm10
Copy link
Contributor

@prklm10 prklm10 commented Sep 16, 2024

We didn't update getTiles function in the generic provider class which was causing these optional parameter not working.
All args after scrollableId was not working.
Updated specs to catch this early.

@prklm10 prklm10 requested a review from a team as a code owner September 16, 2024 10:44
@prklm10 prklm10 merged commit 4e70d5e into master Sep 16, 2024
5 checks passed
@prklm10 prklm10 deleted the PAPP-481_fix branch September 16, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants