Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't add the storage name twice to the scheduled backup name #1923

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

s10
Copy link
Contributor

@s10 s10 commented Dec 23, 2024

Don't add the storage name twice to the scheduled backup name

Adding a storage name twice might make a job name longer than 63 characters and break backup creation

CHANGE DESCRIPTION

Problem:
Scheduled backups are not being created after v1.16.0 in some situations when the storage name is not short.

Cause:
After v1.16.0 storage name is added to the scheduled backup name twice, see PR#1823.
The example of generated pxc-backup name before: cron-dev-1-db-s3-backups-daily-20241220005-372f8
The example of generated pxc-backup name after: cron-dev-1-dbs3-backups-daily-s3-backups-daily-202412230055-372f8

Solution:
Don't add the backup storage name twice to the scheduled backup name.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?
  • Are OpenShift compare files changed for E2E tests (compare/*-oc.yml)?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PXC version?
  • Does the change support oldest and newest supported Kubernetes version?

@pull-request-size pull-request-size bot added the size/S 10-29 lines label Dec 23, 2024
Don't add the storage name twice to the scheduled backup name

Adding a storage name twice might make a job name longer than 63 characters
and break backup creation
@egegunes egegunes added this to the v1.16.1 milestone Dec 23, 2024
@JNKPercona
Copy link
Collaborator

Test name Status
affinity-8-0 passed
auto-tuning-8-0 passed
cross-site-8-0 passed
custom-users-8-0 passed
demand-backup-cloud-8-0 passed
demand-backup-encrypted-with-tls-8-0 passed
demand-backup-8-0 passed
haproxy-5-7 passed
haproxy-8-0 passed
init-deploy-5-7 passed
init-deploy-8-0 passed
limits-8-0 passed
monitoring-2-0-8-0 passed
one-pod-5-7 passed
one-pod-8-0 passed
pitr-8-0 passed
pitr-gap-errors-8-0 passed
proxy-protocol-8-0 passed
proxysql-sidecar-res-limits-8-0 passed
pvc-resize-5-7 passed
pvc-resize-8-0 passed
recreate-8-0 passed
restore-to-encrypted-cluster-8-0 passed
scaling-proxysql-8-0 passed
scaling-8-0 passed
scheduled-backup-5-7 passed
scheduled-backup-8-0 passed
security-context-8-0 passed
smart-update1-8-0 passed
smart-update2-8-0 passed
storage-8-0 passed
tls-issue-cert-manager-ref-8-0 passed
tls-issue-cert-manager-8-0 passed
tls-issue-self-8-0 passed
upgrade-consistency-8-0 failure
upgrade-haproxy-5-7 passed
upgrade-haproxy-8-0 passed
upgrade-proxysql-5-7 passed
upgrade-proxysql-8-0 passed
users-5-7 passed
users-8-0 passed
validation-hook-8-0 passed
We run 42 out of 42

commit: f5e5b85
image: perconalab/percona-xtradb-cluster-operator:PR-1923-f5e5b852

@hors hors merged commit 0757fb4 into percona:main Dec 23, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S 10-29 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants