K8SPSMDB-1174: Improve telemetry requests #1725

egegunes · 2024-11-14T13:29:03Z

CHANGE DESCRIPTION

Before these changes, operator was only sending telemetry requests to version service while cluster is newly deployed. This makes it impossible for us to track usage of new features in long running clusters.

With these changes, operator will configure a cronjob to send telemetry requests every hour at a random minute.

Also, I added some fields that we're missing:

VolumeExpansionEnabled
MCSEnabled
UserManagementEnabled
RoleManagementEnabled

version-service PR: Percona-Lab/percona-version-service#334

CHECKLIST

Jira

Is the Jira ticket created and referenced properly?
Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

Is an E2E test/test case added for the new feature/change?
Are unit tests added where appropriate?
Are OpenShift compare files changed for E2E tests (compare/*-oc.yml)?

Config/Logging/Testability

Are all needed new/changed options added to default YAML files?
Are all needed new/changed options added to the Helm Chart?
Did we add proper logging messages for operator actions?
Did we ensure compatibility with the previous version or cluster upgrade process?
Does the change support oldest and newest supported MongoDB version?
Does the change support oldest and newest supported Kubernetes version?

Before these changes, operator was only sending telemetry requests to version service while cluster is newly deployed. This makes it impossible for us to track usage of new features in long running clusters. With these changes, operator will configure a cronjob to send telemetry requests every hour at a random minute. Also, I added some fields that we're missing: 1. VolumeExpansionEnabled 2. MCSEnabled 3. UserManagementEnabled 4. RoleManagementEnabled

github-actions · 2024-11-14T13:30:56Z

versionserviceclient/version_service/version_service_apply_parameters.go

-	for the version service apply operation.
-
-	Typically these are written to a http.Request.
+/*VersionServiceApplyParams contains all the parameters to send to the API endpoint


[gofmt] _{reported by reviewdog 🐶}

Suggested change

/*VersionServiceApplyParams contains all the parameters to send to the API endpoint

/*

VersionServiceApplyParams contains all the parameters to send to the API endpoint

github-actions · 2024-11-14T13:30:56Z

versionserviceclient/version_service/version_service_apply_responses.go

@@ -46,8 +46,7 @@ func NewVersionServiceApplyOK() *VersionServiceApplyOK {
 	return &VersionServiceApplyOK{}
 }

-/*
-VersionServiceApplyOK describes a response with status code 200, with default header values.
+/*VersionServiceApplyOK handles this case with default header values.


[gofmt] _{reported by reviewdog 🐶}

Suggested change

/*VersionServiceApplyOK handles this case with default header values.

/*

VersionServiceApplyOK handles this case with default header values.

github-actions · 2024-11-14T13:30:57Z

versionserviceclient/version_service/version_service_apply_responses.go

@@ -81,10 +81,9 @@
 	}
 }

-/*
-VersionServiceApplyDefault describes a response with status code -1, with default header values.
+/*VersionServiceApplyDefault handles this case with default header values.


[gofmt] _{reported by reviewdog 🐶}

Suggested change

/*VersionServiceApplyDefault handles this case with default header values.

/*

VersionServiceApplyDefault handles this case with default header values.

github-actions · 2024-11-14T13:30:57Z

versionserviceclient/version_service/version_service_client.go


 	SetTransport(transport runtime.ClientTransport)
 }

 /*
-VersionServiceApply specifics version
+  VersionServiceApply specifics version


[gofmt] _{reported by reviewdog 🐶}

Suggested change

VersionServiceApply specifics version

VersionServiceApply specifics version

github-actions · 2024-11-14T13:30:57Z

versionserviceclient/version_service/version_service_client.go


-Return specific product version
+  Return specific product version


[gofmt] _{reported by reviewdog 🐶}

Suggested change

Return specific product version

Return specific product version

github-actions · 2024-11-14T13:30:59Z

versionserviceclient/version_service/version_service_operator_responses.go

@@ -46,8 +46,7 @@ func NewVersionServiceOperatorOK() *VersionServiceOperatorOK {
 	return &VersionServiceOperatorOK{}
 }

-/*
-VersionServiceOperatorOK describes a response with status code 200, with default header values.
+/*VersionServiceOperatorOK handles this case with default header values.


[gofmt] _{reported by reviewdog 🐶}

Suggested change

/*VersionServiceOperatorOK handles this case with default header values.

/*

VersionServiceOperatorOK handles this case with default header values.

github-actions · 2024-11-14T13:30:59Z

versionserviceclient/version_service/version_service_operator_responses.go

@@ -81,10 +81,9 @@
 	}
 }

-/*
-VersionServiceOperatorDefault describes a response with status code -1, with default header values.
+/*VersionServiceOperatorDefault handles this case with default header values.


[gofmt] _{reported by reviewdog 🐶}

Suggested change

/*VersionServiceOperatorDefault handles this case with default header values.

/*

VersionServiceOperatorDefault handles this case with default header values.

github-actions · 2024-11-14T13:31:00Z

versionserviceclient/version_service/version_service_product_parameters.go

-	for the version service product operation.
-
-	Typically these are written to a http.Request.
+/*VersionServiceProductParams contains all the parameters to send to the API endpoint


[gofmt] _{reported by reviewdog 🐶}

Suggested change

/*VersionServiceProductParams contains all the parameters to send to the API endpoint

/*

VersionServiceProductParams contains all the parameters to send to the API endpoint

github-actions · 2024-11-14T13:31:00Z

versionserviceclient/version_service/version_service_product_responses.go

@@ -46,8 +46,7 @@ func NewVersionServiceProductOK() *VersionServiceProductOK {
 	return &VersionServiceProductOK{}
 }

-/*
-VersionServiceProductOK describes a response with status code 200, with default header values.
+/*VersionServiceProductOK handles this case with default header values.


[gofmt] _{reported by reviewdog 🐶}

Suggested change

/*VersionServiceProductOK handles this case with default header values.

/*

VersionServiceProductOK handles this case with default header values.

github-actions · 2024-11-14T13:31:00Z

versionserviceclient/version_service/version_service_product_responses.go

@@ -81,10 +81,9 @@
 	}
 }

-/*
-VersionServiceProductDefault describes a response with status code -1, with default header values.
+/*VersionServiceProductDefault handles this case with default header values.


[gofmt] _{reported by reviewdog 🐶}

Suggested change

/*VersionServiceProductDefault handles this case with default header values.

/*

VersionServiceProductDefault handles this case with default header values.

pull-request-size bot added the size/L 100-499 lines label Nov 14, 2024

github-actions bot reviewed Nov 14, 2024

View reviewed changes

egegunes marked this pull request as ready for review November 18, 2024 07:53

egegunes requested review from hors, inelpandzic and pooknull as code owners November 18, 2024 07:53

egegunes and others added 3 commits November 18, 2024 10:53

Merge branch 'main' into K8SPSMDB-1174

c7d71b1

Fix unit tests.

c15c9e7

Merge branch 'main' into K8SPSMDB-1174

596155c

inelpandzic approved these changes Nov 22, 2024

View reviewed changes

hors approved these changes Nov 22, 2024

View reviewed changes

egegunes added this to the v1.19.0 milestone Nov 25, 2024

inelpandzic and others added 3 commits November 27, 2024 09:03

Merge branch 'main' into K8SPSMDB-1174

e5cf2cd

Merge branch 'main' into K8SPSMDB-1174

7f9d8de

Merge branch 'main' into K8SPSMDB-1174

9bf84ba

hors merged commit 74f7c8e into main Dec 2, 2024
5 of 7 checks passed

hors deleted the K8SPSMDB-1174 branch December 2, 2024 21:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

K8SPSMDB-1174: Improve telemetry requests #1725

K8SPSMDB-1174: Improve telemetry requests #1725

egegunes commented Nov 14, 2024 •

edited

Loading

github-actions bot Nov 14, 2024

github-actions bot Nov 14, 2024

github-actions bot Nov 14, 2024

github-actions bot Nov 14, 2024

github-actions bot Nov 14, 2024

github-actions bot Nov 14, 2024

github-actions bot Nov 14, 2024

github-actions bot Nov 14, 2024

github-actions bot Nov 14, 2024

github-actions bot Nov 14, 2024

	/*VersionServiceApplyParams contains all the parameters to send to the API endpoint
	/*
	VersionServiceApplyParams contains all the parameters to send to the API endpoint

	/*VersionServiceApplyOK handles this case with default header values.
	/*
	VersionServiceApplyOK handles this case with default header values.

	/*VersionServiceApplyDefault handles this case with default header values.
	/*
	VersionServiceApplyDefault handles this case with default header values.

	VersionServiceApply specifics version
	VersionServiceApply specifics version


		Return specific product version
		Return specific product version

	/*VersionServiceOperatorOK handles this case with default header values.
	/*
	VersionServiceOperatorOK handles this case with default header values.

	/*VersionServiceOperatorDefault handles this case with default header values.
	/*
	VersionServiceOperatorDefault handles this case with default header values.

	/*VersionServiceProductParams contains all the parameters to send to the API endpoint
	/*
	VersionServiceProductParams contains all the parameters to send to the API endpoint

	/*VersionServiceProductOK handles this case with default header values.
	/*
	VersionServiceProductOK handles this case with default header values.

	/*VersionServiceProductDefault handles this case with default header values.
	/*
	VersionServiceProductDefault handles this case with default header values.

K8SPSMDB-1174: Improve telemetry requests #1725

K8SPSMDB-1174: Improve telemetry requests #1725

Conversation

egegunes commented Nov 14, 2024 • edited Loading

CHANGE DESCRIPTION

CHECKLIST

github-actions bot Nov 14, 2024

Choose a reason for hiding this comment

github-actions bot Nov 14, 2024

Choose a reason for hiding this comment

github-actions bot Nov 14, 2024

Choose a reason for hiding this comment

github-actions bot Nov 14, 2024

Choose a reason for hiding this comment

github-actions bot Nov 14, 2024

Choose a reason for hiding this comment

github-actions bot Nov 14, 2024

Choose a reason for hiding this comment

github-actions bot Nov 14, 2024

Choose a reason for hiding this comment

github-actions bot Nov 14, 2024

Choose a reason for hiding this comment

github-actions bot Nov 14, 2024

Choose a reason for hiding this comment

github-actions bot Nov 14, 2024

Choose a reason for hiding this comment

egegunes commented Nov 14, 2024 •

edited

Loading