Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8SPSMDB-1212: Don't disable balancer during restore #1710

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Conversation

egegunes
Copy link
Contributor

@egegunes egegunes commented Nov 9, 2024

K8SPSMDB-1212 Powered by Pull Request Badge

CHANGE DESCRIPTION

Problem:
Operator disables balancer during restore.

Cause:
Old behavior from PBM v1 days.

Solution:
Operator shouldn't disable balancer during restores. Balancer should only be disabled during backups and PBM v2 already does that.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?
  • Are OpenShift compare files changed for E2E tests (compare/*-oc.yml)?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported MongoDB version?
  • Does the change support oldest and newest supported Kubernetes version?

@pull-request-size pull-request-size bot added the size/L 100-499 lines label Nov 9, 2024
@pull-request-size pull-request-size bot added size/XL 500-999 lines and removed size/L 100-499 lines labels Nov 10, 2024
fi
}


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[shfmt] reported by reviewdog 🐶

Suggested change

@egegunes egegunes changed the title [WIP] K8SPSMDB-1212: Disable balancer during backups/restores K8SPSMDB-1212: Disable balancer during backups/restores Nov 10, 2024
@egegunes egegunes force-pushed the K8SPSMDB-1212 branch 3 times, most recently from 60e1af2 to 9e4f2b9 Compare November 11, 2024 15:35
@egegunes egegunes changed the title K8SPSMDB-1212: Disable balancer during backups/restores K8SPSMDB-1212: Don't disable balancer during restore Nov 11, 2024
@egegunes egegunes marked this pull request as ready for review November 13, 2024 06:57
hors
hors previously approved these changes Nov 17, 2024
inelpandzic
inelpandzic previously approved these changes Nov 18, 2024
pooknull
pooknull previously approved these changes Nov 21, 2024
@egegunes egegunes added this to the v1.19.0 milestone Nov 25, 2024
@egegunes egegunes dismissed stale reviews from hors, inelpandzic, and pooknull via 1cdf4d6 December 4, 2024 06:03
inelpandzic
inelpandzic previously approved these changes Dec 4, 2024
@hors hors self-requested a review December 4, 2024 07:52
hors
hors previously approved these changes Dec 4, 2024
@hors hors self-requested a review December 4, 2024 20:08
@egegunes egegunes dismissed stale reviews from hors and inelpandzic via 60691b3 December 9, 2024 15:05
@pull-request-size pull-request-size bot added size/L 100-499 lines and removed size/XL 500-999 lines labels Dec 9, 2024
Copy link
Contributor

@inelpandzic inelpandzic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Pls just check those failing tests.

}


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[shfmt] reported by reviewdog 🐶

Suggested change

@JNKPercona
Copy link
Collaborator

Test name Status
arbiter passed
balancer passed
custom-replset-name passed
custom-tls passed
custom-users-roles passed
custom-users-roles-sharded passed
cross-site-sharded passed
data-at-rest-encryption passed
data-sharded passed
demand-backup passed
demand-backup-fs passed
demand-backup-eks-credentials-irsa passed
demand-backup-physical passed
demand-backup-physical-sharded passed
demand-backup-sharded passed
expose-sharded passed
ignore-labels-annotations passed
init-deploy passed
finalizer passed
ldap passed
ldap-tls passed
limits passed
liveness passed
mongod-major-upgrade passed
mongod-major-upgrade-sharded passed
monitoring-2-0 passed
multi-cluster-service passed
non-voting passed
one-pod passed
operator-self-healing-chaos passed
pitr passed
pitr-sharded passed
pitr-physical passed
pvc-resize passed
recover-no-primary passed
replset-overrides passed
rs-shard-migration passed
scaling passed
scheduled-backup passed
security-context passed
self-healing-chaos passed
service-per-pod passed
serviceless-external-nodes passed
smart-update passed
split-horizon passed
stable-resource-version passed
storage passed
tls-issue-cert-manager passed
upgrade passed
upgrade-consistency passed
upgrade-consistency-sharded-tls passed
upgrade-sharded passed
users passed
version-service passed
We run 54 out of 54

commit: 0287bd3
image: perconalab/percona-server-mongodb-operator:PR-1710-0287bd33

@hors hors merged commit 0c06f27 into main Dec 11, 2024
17 checks passed
@hors hors deleted the K8SPSMDB-1212 branch December 11, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L 100-499 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants