K8SPSMDB-675: allow enabling/disabling sharding on a running cluster #1706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pooknull
requested review from
tplavcic,
nmarukovich,
ptankov,
jvpasinatto,
eleo007,
hors,
egegunes and
inelpandzic
as code owners
egegunes
reviewed
Nov 12, 2024
| @@ -57,7 +59,9 @@ const ( | |||
|
|
|||
| // CheckNSetDefaults sets default options, overwrites wrong settings | |||
| // and checks if other options' values valid | |||
| func (cr *PerconaServerMongoDB) CheckNSetDefaults(platform version.Platform, log logr.Logger) error { | |||
| func (cr *PerconaServerMongoDB) CheckNSetDefaults(ctx context.Context, platform version.Platform) error { | |||
| log := logf.FromContext(ctx) | |||
| @@ -262,6 +262,8 @@ const ( | |||
| AppStatePaused AppState = "paused" | |||
| AppStateReady AppState = "ready" | |||
| AppStateError AppState = "error" | |||
|
|
|||
| AppStateSharding AppState = "sharding" | |||
There was a problem hiding this comment.
i don't think this should be type AppState but I know that we use a custom condition struct rather than using the one exported from meta/v1. we need to start using it in near future
pkg/apis/psmdb/v1/psmdb_types.go
Outdated
Comment on lines
327
to
328
| ConditionEnabled ConditionStatus = "Enabled" | ||
| ConditionDisabled ConditionStatus = "Disabled" |
There was a problem hiding this comment.
can't we use ConditionTrue and ConditionFalse instead of these?
Comment on lines
+1204
to
+1210
| for i, cond := range s.Conditions { | ||
| if cond.Type != c.Type { | ||
| continue | ||
| } | ||
| s.Conditions[i] = c | ||
| } | ||
| s.Conditions = append(s.Conditions, c) |
There was a problem hiding this comment.
hmm we're changing our behavior but i think it's OK.
egegunes
approved these changes
Nov 21, 2024
inelpandzic
approved these changes
Nov 21, 2024
commit: 9945cb5 |
hors
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/K8SPSMDB-675
DESCRIPTION
Problem:
If backup is enabled, it is not possible to switch the
spec.sharding.enabledsetting because PBM is unable to detect the change.Solution:
When backup is enabled and a change is made to
spec.sharding.enabled, the operator will first pause the cluster. During this pause, the statefulsets will be updated. After the updates are complete, the operator will then unpause the cluster.CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
compare/*-oc.yml)?Config/Logging/Testability