K8SPG-597 - Update monitoring test #2871
reviewdog [shellcheck] report
reported by reviewdog 🐶
Findings (0)
Filtered Findings (18)
hack/update-pgmonitor-installer.sh|33 col 1| Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
hack/update-pgmonitor-installer.sh|39 col 12| Expressions don't expand in single quotes, use double quotes for that.
hack/update-pgmonitor-installer.sh|52 col 8| Expressions don't expand in single quotes, use double quotes for that.
hack/create-kubeconfig.sh|62 col 12|
hack/create-todo-patch.sh|39 col 26| See if you can use ${variable//search/replace} instead.
hack/create-todo-patch.sh|42 col 91| Expressions don't expand in single quotes, use double quotes for that.
hack/create-todo-patch.sh|49 col 91| Expressions don't expand in single quotes, use double quotes for that.
installers/olm/install.sh|37 col 108| Note that A && B || C is not if-then-else. C may run when A is true.
installers/olm/install.sh|108 col 70| Note that A && B || C is not if-then-else. C may run when A is true.
installers/olm/install.sh|122 col 98| Note that A && B || C is not if-then-else. C may run when A is true.
installers/olm/build-image.sh|10 col 5| Use 'pushd ... || exit' or 'pushd ... || return' in case pushd fails.
installers/olm/build-image.sh|10 col 11| Double quote to prevent globbing and word splitting.
installers/olm/build-image.sh|15 col 5| Use 'popd ... || exit' or 'popd ... || return' in case popd fails.
installers/olm/generate.sh|72 col 6| Double quote to prevent globbing and word splitting.
e2e-tests/vars.sh|8 col 32| test_name is referenced but not assigned.
e2e-tests/vars.sh|10 col 8| Declare and assign separately to avoid masking return values.
e2e-tests/vars.sh|27 col 1| date appears unused. Verify use (or export if used externally).
e2e-tests/vars.sh|28 col 1| sed appears unused. Verify use (or export if used externally).