K8SPG-597 Fixing test case upgrade-minor to work with postures images which have minor numbers in the image name #821
Conversation
…he image name, also, the calculation was buggy when the version contains a dot and a minor number, e.g. 16.3
ptankov
requested review from
hors,
inelpandzic,
egegunes,
jvpasinatto and
eleo007
| @@ -13,25 +13,25 @@ commands: | |||
| curl -s "https://raw.githubusercontent.com/percona/percona-postgresql-operator/v${lower_ver}/deploy/cr.yaml" >"${TEMP_DIR}/cr_lower.yaml" | |||
|
|
|||
| # get PG version which we want to test | |||
| pg_ver=$(echo "$IMAGE_POSTGRESQL" | cut -d':' -f2 | grep -oE '\-ppg[0-9]+-' | grep -oE '[0-9]+' | tr -d '-') | |||
| pg_ver=$PG_VER | |||
There was a problem hiding this comment.
Just make sure that these versions are the same and that there was no intention that we provide image with the different version.
Can we just use PG_VER and not set another variable?
There was a problem hiding this comment.
Can we just use PG_VER and not set another variable?
Well, we could, but later we havepg_ver=$((pg_ver - 1))
There was a problem hiding this comment.
Just make sure that these versions are the same and that there was no intention that we provide image with the different version.
Well, we set PG_VER here which is basically a more robust way than the one I'm obsoleting right now, because it works with minor numbers, as well.
There was a problem hiding this comment.
Hi, I would add passed param verification or modification. We rely that this is major version without minor (16 but not 16.3 or modify 16.3 to 16).
…ead of calculating version from image name
commit: 579f033 |
ptankov
changed the title
* K8SPG-597 Update images and versions for 2.4.0 release (#819) * K8SPG-597 Update images and versions for 2.4.0 release * supply minor tag versions * update the image in upgrade.yaml * K8SPG-600: Fix failed backup status (#820) * Fix failed backup status * fix lint * fix fmt * fix regression and status update * K8SPG-518: Fix WAL archiving on Openshift (#823) * K8SPG-597 Fixing test case upgrade-minor to work with postures images which have minor numbers in the image name (#821) * We now have env var PG_VER so no need to calculate the version from the image name, also, the calculation was buggy when the version contains a dot and a minor number, e.g. 16.3 * Refactor upgrade-cluster.yaml to use PG_VER environment variable instead of calculating version from image name * K8SPG-597 - Update monitoring test (#824) * K8SPG-254: Fix major upgrade on Openshift (#826) --------- Co-authored-by: Andrii Dema <[email protected]> Co-authored-by: Ege Güneş <[email protected]> Co-authored-by: Tomislav Plavcic <[email protected]> Co-authored-by: Viacheslav Sarzhan <[email protected]>
CHANGE DESCRIPTION
Problem:
The test case upgrade-minor fails when the
PGO_POSTGRES_IMAGEcontains an image with minor version, e.g.percona/percona-postgresql-operator:2.4.0-ppg16.3-postgres. Now I use thePG_VERenv var.Cause:
Short explanation of the root cause of the issue if applicable.
Solution:
Short explanation of the solution we are providing with this PR.
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
Config/Logging/Testability