Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8SPG-401: Fix panic when checking PMM enabled #526

Merged
merged 6 commits into from
Oct 9, 2023

Conversation

inelpandzic
Copy link
Contributor

@inelpandzic inelpandzic commented Oct 4, 2023

K8SPG-401 Powered by Pull Request Badge

CHANGE DESCRIPTION

Problem:
When PMM spec is missing the operator crashes.

Cause:
When checking if spec.PMM.enabled, PMM is not checked if it is nil.

Solution:
Check it.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are the manifests (crd/bundle) regenerated if needed?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PG version?
  • Does the change support oldest and newest supported Kubernetes version?

@JNKPercona
Copy link
Collaborator

Test name Status
demand-backup passed
init-deploy passed
monitoring passed
operator-self-healing passed
scaling passed
scheduled-backup passed
self-healing passed
start-from-backup passed
telemetry-transfer passed
users passed
We run 10 out of 10

commit: 093074f
image: perconalab/percona-postgresql-operator:PR-526-093074f11

@hors hors merged commit 8490610 into main Oct 9, 2023
11 checks passed
@hors hors deleted the k8spg-401-handle-missing-pmm-section branch October 9, 2023 09:02
@spron-in
Copy link
Collaborator

spron-in commented Dec 4, 2023

Fixes #588

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants