Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVEREST-1762 | Prevent Helm from deleting Subscriptions #452

Merged
merged 8 commits into from
Dec 18, 2024

Conversation

mayankshah1607
Copy link
Member

  • Adding the helm.sh/resource-policy: keep annotation to a resource will ensure that Helm does not remove it during upgrade/uninstall
  • The pre-delete hook takes care of deleting the subscription during uninstall.

This way, a Subscription may not be removed after creating it

Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
@mayankshah1607 mayankshah1607 requested a review from a team as a code owner December 18, 2024 04:54
Signed-off-by: Mayank Shah <[email protected]>
Signed-off-by: Mayank Shah <[email protected]>
Copy link
Contributor

@oksana-grishchenko oksana-grishchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

recharte
recharte previously approved these changes Dec 18, 2024
@mayankshah1607 mayankshah1607 merged commit 4cc3b73 into main Dec 18, 2024
3 checks passed
@mayankshah1607 mayankshah1607 deleted the EVEREST-1762 branch December 18, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants