Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow proxysql entrypoint to work with helm config #1065

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dcaputo-harmoni
Copy link

The current entrypoint script attempts to modify /etc/proxysql/proxysql.cnf using sed (replacing sensitive data such as usernames / passwords with environment variables) however when deploying proxysql as part of the pxc-db helm chart, where proxysql.configuration is specified, a configmap (mysql-db-proxysql) is created and mounted to the /etc/proxysql path, which is by definition read only.

As a result, the entrypoint script generates errors on startup, but also prevents the usage of the generic values such as admin:admin which would otherwise be replaced by environment variables in entrypoint.sh, forcing the hardcoding of these values in a helm config which is not secure.

The proposed change simply copies the config file form /etc/proxysql/proxysql.cnf to /etc/proxysql.cnf before performing the modifications, and then uses that config file when starting proxysql.

@it-percona-cla
Copy link

it-percona-cla commented Nov 30, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants