Allow proxysql entrypoint to work with helm config #1065
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current entrypoint script attempts to modify
/etc/proxysql/proxysql.cnf
using sed (replacing sensitive data such as usernames / passwords with environment variables) however when deploying proxysql as part of thepxc-db
helm chart, whereproxysql.configuration
is specified, a configmap (mysql-db-proxysql
) is created and mounted to the/etc/proxysql
path, which is by definition read only.As a result, the entrypoint script generates errors on startup, but also prevents the usage of the generic values such as
admin:admin
which would otherwise be replaced by environment variables inentrypoint.sh
, forcing the hardcoding of these values in a helm config which is not secure.The proposed change simply copies the config file form
/etc/proxysql/proxysql.cnf
to/etc/proxysql.cnf
before performing the modifications, and then uses that config file when starting proxysql.