Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PBM-1454-Configuration-file-for-all-pbm-agent-s-options #1065

Merged
merged 31 commits into from
Dec 17, 2024

Conversation

veceraj
Copy link
Collaborator

@veceraj veceraj commented Dec 9, 2024

PR for https://perconadev.atlassian.net/browse/PBM-1454

The PR adds the ability to use configuration file for all PBM Agent options.

This was achieved by using Cobra and Viper.

@veceraj veceraj requested a review from boris-ilijic as a code owner December 9, 2024 07:14
@it-percona-cla
Copy link

it-percona-cla commented Dec 9, 2024

CLA assistant check
All committers have signed the CLA.

boris-ilijic
boris-ilijic previously approved these changes Dec 16, 2024
Copy link
Member

@boris-ilijic boris-ilijic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please see one thing that should be improved.

pbm/log/logger.go Outdated Show resolved Hide resolved
@veceraj veceraj merged commit b1fc636 into dev Dec 17, 2024
23 checks passed
@veceraj veceraj deleted the PBM-1454-Configuration-file-for-all-pbm-agent-s-options branch December 17, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants