log opts getter and update print

cmd/pbm-agent/main.go

@@ -207,7 +207,13 @@ func runAgent(
 	defer logger.Close()
 
 	viper.OnConfigChange(func(e fsnotify.Event) {
+		oldOpts := logger.Opts()
 		logger.SetOpts(buildLogOpts())
+		newOpts := logger.Opts()
+		if *oldOpts != *newOpts {
+			logger.Printf("log options updated: log-path=%s, log-level:%s, log-json:%t",
+				newOpts.LogPath, newOpts.LogLevel, newOpts.LogJSON)
+		}
 	})
 
 	ctx = log.SetLoggerToContext(ctx, logger)

pbm/log/discard.go

@@ -54,6 +54,8 @@ func (discardLoggerImpl) Output(ctx context.Context, e *Entry) error {
 	return nil
 }
 
+func (discardLoggerImpl) Opts() *Opts { return nil }
+
 func (discardLoggerImpl) SetOpts(cfg *Opts) {
 }
 

pbm/log/log.go

@@ -35,6 +35,7 @@ type Logger interface {
 	Error(event, obj, opid string, epoch primitive.Timestamp, msg string, args ...any)
 	Fatal(event, obj, opid string, epoch primitive.Timestamp, msg string, args ...any)
 	Output(ctx context.Context, e *Entry) error
+	Opts() *Opts
 	SetOpts(cfg *Opts)
 }
 

pbm/log/logger.go

@@ -306,6 +306,14 @@ func (l *loggerImpl) Output(ctx context.Context, e *Entry) error {
 	return rerr
 }
 
+func (l *loggerImpl) Opts() *Opts {
+	return &Opts{
+		LogPath:  l.logger.logPath,
+		LogJSON:  l.logJSON,
+		LogLevel: l.logLevel.String(),
+	}
+}
+
 func (l *loggerImpl) SetOpts(cfg *Opts) {
 	if cfg == nil {
 		return
@@ -314,12 +322,6 @@ func (l *loggerImpl) SetOpts(cfg *Opts) {
 	l.mu.Lock()
 	defer l.mu.Unlock()
 
-	oldOpts := &Opts{
-		LogPath:  l.logger.logPath,
-		LogJSON:  l.logJSON,
-		LogLevel: l.logLevel.String(),
-	}
-
 	if cfg.LogPath != "" && l.logger.logPath != cfg.LogPath {
 		l.createLogger(cfg.LogPath)
 	}
@@ -329,14 +331,4 @@ func (l *loggerImpl) SetOpts(cfg *Opts) {
 	if l.logJSON != cfg.LogJSON {
 		l.logJSON = cfg.LogJSON
 	}
-
-	newOpts := &Opts{
-		LogPath:  l.logger.logPath,
-		LogJSON:  l.logJSON,
-		LogLevel: l.logLevel.String(),
-	}
-
-	if *oldOpts != *newOpts {
-		fmt.Printf("Updated log options: %+v\n", newOpts)
-	}
 }