Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVEREST-1700: create secret if it does not exist #596

Merged
1 commit merged into from
Nov 29, 2024

Conversation

ghost
Copy link

@ghost ghost commented Nov 27, 2024

CHANGE DESCRIPTION

Problem:
EVEREST-1700

Short explanation of the problem.

  • PXC did not fill in missing fields for a PMM secret before if it was already created. Now it does.

Solution:

  • Create the secret if it does not exist

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?

Tests

  • Is an Integration test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

- PXC properly fills the missing fields
@ghost ghost enabled auto-merge (squash) November 27, 2024 15:42
@ghost ghost merged commit 6754173 into main Nov 29, 2024
5 checks passed
@ghost ghost deleted the EVEREST-1700-create-secret branch November 29, 2024 08:21
mayankshah1607 added a commit that referenced this pull request Dec 24, 2024
Signed-off-by: Mayank Shah <[email protected]>
mayankshah1607 added a commit that referenced this pull request Dec 24, 2024
Signed-off-by: Mayank Shah <[email protected]>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant