Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PERA-1048 :: Re-merge in KMP Module after CI fix #18

Closed
wants to merge 2 commits into from
Closed

PERA-1048 :: Re-merge in KMP Module after CI fix #18

wants to merge 2 commits into from

Conversation

michaeltchuang
Copy link
Collaborator

@michaeltchuang michaeltchuang commented Oct 30, 2024 •
edited
Loading

Pull Request Template

Description

  • Re-merge in wallet-sdk KMP Module after CI fix (excluding unnecessary file)
  • Updated Kotlin to 2.X.X
  • Added a commented Ktor library since we'll use it later

Related Issues

Checklist

  • Have you tested your changes locally?
  • Have you reviewed the code for any potential issues?
  • Have you documented any necessary changes in the project's documentation?
  • Have you added any necessary tests for your changes?
  • Have you updated any relevant dependencies?

Additional Notes

  • Sanity check app to see if you see any issues after we upgraded to Kotlin 2.X.X
  • This can go out in 5.12.0 if there are bugs in Asset Inbox build, or it's fine to go in next feature build

@michaeltchuang michaeltchuang added the gitops gitops tasks label Oct 30, 2024
@michaeltchuang michaeltchuang added this to the 5.12.0 milestone Oct 30, 2024
@michaeltchuang michaeltchuang marked this pull request as ready for review October 30, 2024 03:01
@michaeltchuang michaeltchuang marked this pull request as draft October 30, 2024 03:09
@michaeltchuang
Copy link
Collaborator Author

superseded by this PR #22

@michaeltchuang
Copy link
Collaborator Author

made a mistake, looks like PR #22 was supposed to merge into this PR branch...so re-opening

@michaeltchuang michaeltchuang reopened this Nov 1, 2024
@michaeltchuang
Copy link
Collaborator Author

switching back to this PR superseded by this PR #22, closing again

@michaeltchuang michaeltchuang deleted the feat/PERA-1015-pr branch November 8, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitsinsar mitsinsar Awaiting requested review from mitsinsar mitsinsar is a code owner

@yasin-ce yasin-ce Awaiting requested review from yasin-ce yasin-ce will be requested when the pull request is marked ready for review yasin-ce is a code owner

Assignees
No one assigned
Labels
gitops gitops tasks
Projects
None yet
Milestone
5.12.0
Development

Successfully merging this pull request may close these issues.
1 participant
@michaeltchuang