This repository has been archived by the owner on Dec 1, 2023. It is now read-only.
Remove tutorial in order to have any changes #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsheff
suggested changes
Sep 16, 2022
| The best option here is to identify (within `check_samplesheet.py`) the logic responsible for modification | ||
| of the input file and move it to separate Python script (`bin/place_the_script_here.py`). That way one can | ||
| still remove all the logic responsible for validation and replace it with `eido`, and modify the input | ||
| `samplesheet.csv` using newly extracted Python script. |
There was a problem hiding this comment.
Would this also be possible by using PEP capabilities, as maybe an alternative approach?
There was a problem hiding this comment.
I'm not sure how popular is that in nf-core pipelines but I talked about it with James and he mentioned something about moving this logic to separate workflow in the pipeline. In that case this problem will disappear.
|
|
||
| ## 6. Adjust the workflow responsible for input check | ||
| When incorporating new modules, the workflow will change. In my case changes were needed in | ||
| `modules/local/samplesheet_check.nf` and `subworkflows/local/input_check.nf`. |
There was a problem hiding this comment.
You need to specify in a bit more detail what these changes were.
There was a problem hiding this comment.
Same question as above. Do we want to go into details here when whole PR is available to see the changes exactly?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.