Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(eslint): top-level eslint #782

Closed
wants to merge 3 commits into from
Closed

refactor(eslint): top-level eslint #782

wants to merge 3 commits into from

Conversation

TalDerei
Copy link
Contributor

@TalDerei TalDerei commented Mar 18, 2024

references #723

Removes eslint-config-custom package and implements top-level flat ESLint configuration, serving as the the primary linter configuration for all packages. package specific .eslintrc.cjs files are instructed to use the configuration defined in the top-level, and it more explicitly specifies the package's tsconfig.json for TypeScript-related linting.

@TalDerei TalDerei self-assigned this Mar 18, 2024
@grod220
Copy link
Contributor

grod220 commented Mar 18, 2024

Curious, do you think this solves a problem we have? The current config we have seems to be a turborepo standard thing. Moving it to the top level seems to be a net-neutral effect.

@TalDerei
Copy link
Contributor Author

I think by removing dedicated configuration packages and leveraging inheritance, it has the nice property of reducing potential duplication. Since it extends the top-level configuration, it's also clearer when there are package-specific overrides, which can make it easier to read. This applies to the tsconfig.json as well.

I was sequentially going down the NPM publishing tracking issue to reduce our backlog.

@grod220
Copy link
Contributor

grod220 commented Mar 18, 2024

I suppose my observation is that it doesn't remove the need for dedicated configs, it was using inheritance before, and there does not seem to be any de-duplication. At best, it seems like a net-neutral change. And in that case, I think it's best to stick with the default turborepo recommendation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants