-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): TextInput updates #1942
Conversation
|
Visit the preview URL for this PR (updated for commit 56146cf): https://penumbra-ui-preview--pr1942-feat-text-input-upda-7qlsewow.web.app (expires Wed, 18 Dec 2024 09:52:10 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 709d729610ef7a6369b23f1cb2b820a60cc685b1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
can you add a changeset?
</Text> | ||
) : ( | ||
<Text small truncate={truncate}> | ||
<Text variant={density === 'sparse' ? 'strong' : 'small'} truncate={truncate}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
praise: variant property on density is a nice feature
Somehow changeset bot didn't notice that the changeset exists in this PR |
In this PR:
Text
component, addedvariant
property to manage dynamic font types, added new text stylesDensity
component, addedvariant
property to manage dynamic density typesiconOnly="adornment"
prop in Button component to matchIconAdornment
in FigmaChecks TextInput, Typography, IconAdornment in #1937
Interactive: https://penumbra-ui-preview--pr1942-feat-text-input-upda-7qlsewow.web.app/?path=/docs/ui-library-textinput--docs