views: prop for optionally displaying value on ValueViewComponent #1923
Conversation
🦋 Changeset detectedLatest commit: 73ffd08 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Visit the preview URL for this PR (updated for commit 73ffd08): https://penumbra-ui-preview--pr1923-approval-dialogue-re-paxexa97.web.app (expires Mon, 02 Dec 2024 15:41:28 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 709d729610ef7a6369b23f1cb2b820a60cc685b1 |
| /** | ||
| * If false, the amount will not be displayed. | ||
| */ | ||
| showValue?: boolean; |
There was a problem hiding this comment.
please review the storybook preview link
packages/ui/src/ValueView/index.tsx
Outdated
| @@ -58,19 +62,22 @@ export const ValueViewComponent = <SelectedContext extends Context = 'default'>( | |||
| priority = 'primary', | |||
| hideSymbol = false, | |||
There was a problem hiding this comment.
thought: hmm, maybe we should have called this showSymbol with a default to true 🤔
There was a problem hiding this comment.
I think that’s clearer now — it’s been renamed to showSymbol. Currently, the v2 ValueViewComponent is only used once within the dex-explorer in the SummaryCard.
the V2
ValueViewComponentneeds ashowValueprop. For instance the prepaid claim fee amount can't be shown in the public view and will need to set the prop tofalse.