Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(minifront): #1811: multiwallet support #1853

Merged
merged 6 commits into from
Oct 14, 2024
Merged

feat(minifront): #1811: multiwallet support #1853

merged 6 commits into from
Oct 14, 2024

Conversation

VanishMax
Copy link
Contributor

Closes #1811

Relates to prax-wallet/prax#209 and prax-wallet/prax#210

Depends on #1852

The video displays the logic of this PR:

  • When 2+ providers are injected into the app, the "Connect" button displays the dialog with the list of injected provider manifests
  • When only 1 provider is injected, the "Connect" button automatically connects to it
  • When 0 providers are installed, minifronts proposes to install Prax
  • When a provider is connected, reloading the page reconnects to the first connected provider
mult.mp4

@VanishMax VanishMax requested a review from a team October 11, 2024 11:42
@VanishMax VanishMax self-assigned this Oct 11, 2024
@penumbra-zone penumbra-zone deleted a comment from github-actions bot Oct 11, 2024
@penumbra-zone penumbra-zone deleted a comment from github-actions bot Oct 11, 2024
Base automatically changed from feat/dialog-radio-group to main October 11, 2024 11:53
grod220
grod220 approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@grod220 grod220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@VanishMax VanishMax merged commit 45c6751 into main Oct 14, 2024
6 checks passed
@VanishMax VanishMax deleted the feat/#1811-multiwallet-support branch October 14, 2024 06:50
@VanishMax VanishMax mentioned this pull request Oct 16, 2024
Merged
@TalDerei TalDerei mentioned this pull request Oct 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grod220 grod220 grod220 approved these changes

Assignees

@VanishMax VanishMax

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minifront & connecting to non-prax wallets
2 participants
@VanishMax @grod220