Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Slider component #1738

Merged
merged 6 commits into from
Sep 3, 2024
Merged

Add Slider component #1738

merged 6 commits into from
Sep 3, 2024

Conversation

JasonMHasperhoven
Copy link
Contributor

@JasonMHasperhoven JasonMHasperhoven commented Aug 28, 2024

Implements #1715

image

Copy link

changeset-bot bot commented Aug 28, 2024

🦋 Changeset detected

Latest commit: 22551a4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@penumbra-zone/ui Minor
minifront Patch
node-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 28, 2024

Visit the preview URL for this PR (updated for commit 22551a4):

https://penumbra-ui-preview--pr1738-slider-ckl184n2.web.app

(expires Thu, 05 Sep 2024 14:29:08 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 709d729610ef7a6369b23f1cb2b820a60cc685b1

@JasonMHasperhoven JasonMHasperhoven changed the title Add Slider component [WIP] Add Slider component Aug 28, 2024
@JasonMHasperhoven JasonMHasperhoven changed the title [WIP] Add Slider component Add Slider component Aug 28, 2024
@JasonMHasperhoven JasonMHasperhoven requested a review from a team August 28, 2024 12:37
packages/ui/src/Slider/index.test.tsx Show resolved Hide resolved
packages/ui/src/Slider/index.tsx Outdated Show resolved Hide resolved
packages/ui/src/Slider/index.tsx Show resolved Hide resolved
Copy link
Contributor

@VanishMax VanishMax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loving the result!

@TalDerei TalDerei self-requested a review August 30, 2024 06:58
Copy link
Contributor

@TalDerei TalDerei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JasonMHasperhoven JasonMHasperhoven merged commit d938456 into main Sep 3, 2024
8 checks passed
@JasonMHasperhoven JasonMHasperhoven deleted the slider branch September 3, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants