feat(minifront, ui): #1732: v2 header #1734
Conversation
|
|
Visit the preview URL for this PR (updated for commit 15acfb0): https://penumbra-ui-preview--pr1734-feat-1732-v2-header-j3nb23wg.web.app (expires Sat, 07 Sep 2024 07:06:51 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 709d729610ef7a6369b23f1cb2b820a60cc685b1 |
# Conflicts: # apps/minifront/src/components/syncing-dialog/index.tsx
| import type { PagePath } from '../metadata/paths.ts'; | ||
|
|
||
| /** @todo: Remove this function and its uses after we switch to v2 layout */ | ||
| export const getV2Link = (path: PagePath) => `/v2${path}`; |
There was a problem hiding this comment.
thought: maybe instead of manipulating strings to create paths, we should rely on utilities provided by the router https://reactrouter.com/en/main/hooks/use-resolved-path
not a task for this PR
There was a problem hiding this comment.
suggestion: a general note about segmented pickers — when applied to text, they can create what feels like a jagged transition between tabs. for instance, reference "Asset Balances" and "Transfer Assets" sections between the dashboard and transfer tabs. I believe Jesse intended this as a feature, but it doesn't feel smooth to me. I'm curious if others experience this as well.
Screen.Recording.2024-08-28.at.11.59.08.PM.mov
| import { SyncAnimation } from './sync-animation'; | ||
| import { Text } from '@penumbra-zone/ui/Text'; | ||
| import { useEffect, useState } from 'react'; | ||
| import { useSyncProgress } from '@penumbra-zone/ui/components/ui/block-sync-status'; | ||
|
|
||
| type StatusSelector = |
There was a problem hiding this comment.
thought: The old sync bar subtly provided useful information about whether the blocks were synced and the latest block height. We should consider whether this is something we want to retain.
There was a problem hiding this comment.
this info is now in its own popover and in the syncing dialog. Sam continues working on different states of this popover (e.g. if there's an error, colorize the popover trigger in red), so we will see more information about the syncing process later.
i'd appreciate if you could send your notes about what info about the sync should or should not be displayed to Sam
There was a problem hiding this comment.
as for the text transitions, i am personally ok about it, or maybe i got used to it. We make a poll from this question and ask the team for opinions
There was a problem hiding this comment.
My 2 cents:
- The transition for the texts doesn't look good imo, but it's a subjective thing.
- It's true that we lost the block information that's now hidden, but at the same time the most relevant thing to the user is the progress bar.
There was a problem hiding this comment.
I think this is sufficient for now, but we should revisit the segmented pickers for text in a future iteration of the V2 header.
VanishMax
force-pushed
the
feat/#1732-v2-header
branch
from
91cbffd to
0874073
Compare
|
@turbocrime @TalDerei @JasonMHasperhoven a reminder that this is ready for re-review |
There was a problem hiding this comment.
approving
reviewing the icon component again i noticed that the manifest type is strange (some fields require index access, some fields require dot notation, optionality is incorrect) so i filed #1751 to improve it.
Closes #1732
Closes #1730
Implements the header of the minifront v2:
Read more in the changeset.
This PR got huge because many UI components were not ready for it, so I had to create or modify it here.
kap.mp4