Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove all @buf deps in favor of @penumbra-zone/protobuf #1728

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

turbocrime
Copy link
Contributor

Some rebase reintroduced @buf/penumbra-zone_penumbra deps. These are removed, and now:

  • @penumbra-labs/registry is updated to the version that uses @penumbra-zone/protobuf
  • syncpack forbids @buf/penumbra-zone_penumbra.* everywhere
  • syncpack forbids @buf/** dependencies in published packages
  • @bufbuild/protobuf and @connectrpc/* are removed from root package json
  • packages that depend on @bufbuild/protobuf and @connectrpc/* now specify those dependencies

@turbocrime turbocrime requested a review from a team August 22, 2024 21:20
Copy link

changeset-bot bot commented Aug 22, 2024

🦋 Changeset detected

Latest commit: 1080135

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@penumbra-zone/perspective Patch
node-status Patch
@penumbra-zone/storage Patch
@penumbra-zone/client Patch
minifront Patch
@repo/ui Patch
@penumbra-zone/services Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 22, 2024

Visit the preview URL for this PR (updated for commit 1080135):

https://penumbra-ui-preview--pr1728-turbocrime-forbid-bu-m268858q.web.app

(expires Thu, 29 Aug 2024 21:24:46 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 709d729610ef7a6369b23f1cb2b820a60cc685b1

@turbocrime turbocrime merged commit e952e03 into main Aug 23, 2024
8 checks passed
@turbocrime turbocrime deleted the turbocrime/forbid-buf-deps branch August 23, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants