Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create SegmentedControl component #1635

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Create SegmentedControl component #1635

merged 2 commits into from
Aug 5, 2024

Conversation

jessepinho
Copy link
Contributor

@jessepinho jessepinho commented Aug 2, 2024 •
edited
Loading

This PR creates a <SegmentedControl /> component built on top of Radix's <RadioGroup /> component, making it fully accessible and keyboard-controllable.

image

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 2, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 68d7add

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 2, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 68d7add):

https://penumbra-ui-preview--pr1635-jessepinho-segmented-gabxck8d.web.app

(expires Fri, 09 Aug 2024 22:32:11 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 709d729610ef7a6369b23f1cb2b820a60cc685b1

jessepinho
jessepinho commented Aug 2, 2024
View reviewed changes
packages/ui/src/SegmentedControl/index.stories.tsx
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://penumbra-ui-preview--pr1635-jessepinho-segmented-gabxck8d.web.app/?path=/docs/ui-library-segmentedcontrol--docs

@jessepinho jessepinho marked this pull request as ready for review August 2, 2024 22:38
@jessepinho jessepinho requested a review from a team August 2, 2024 22:38
@jessepinho jessepinho merged commit 4979b15 into jessepinho/more-components Aug 5, 2024
8 checks passed
@jessepinho jessepinho deleted the jessepinho/segmented-control branch August 5, 2024 17:53
jessepinho added a commit that referenced this pull request Aug 5, 2024
@jessepinho
Create more components in preparation for the v2 assets/transactions …
33f70a1 
…pages (#1634)

* Add table title functionality

* Start building v2 pages

* Build out Identicon properly

* Start building out assets table

* Add truncate to Text

* Add iconOnly='adornment' to Button

* Create the new CopyToClipboardButton

* Create Shrink0 util component

* Create AddressViewComponent

* Create initial SegmentedControl

* Convert to using Radix's RadioGroup

* Add docblock

* Update hover overlay

* Fix border

* Rename 'reset' to 'buttonBase'; add a cursor

* Use buttonBase elsewhere as well

* Add type to props

* Update AddressViewComponent tests

* Delete code that will be part of another PR

* Add tests

* Delete SegmentedControl for now

* Return null

* Create SegmentedControl component (#1635)

* Create SegmentedControl component

* Add density tag
@VanishMax VanishMax mentioned this pull request Aug 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VanishMax VanishMax VanishMax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jessepinho @VanishMax