-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<Card />
component
#1606
<Card />
component
#1606
Conversation
|
Visit the preview URL for this PR (updated for commit 1cfad00): https://penumbra-ui-preview--pr1606-jessepinho-card-2-rz1wxq2j.web.app (expires Thu, 08 Aug 2024 16:45:16 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 709d729610ef7a6369b23f1cb2b820a60cc685b1 |
f9d6f4e
to
b8d4200
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/ui/src/Card/storiesBg.png
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a wish: can this image be compressed a little? When I first entered the Card's storybook, it was empty for like 5 seconds until the image loaded
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yes — good call. It was 8MB! I've compressed it to a 100kb JPEG.
…ra UI component (#1584) * Add blurs and base colors to theme * Add Xxl text size * Tweak blur radius; add z indexes * Create initial Dialog component * Allow for button groups to always be a column * Build out more of the Dialog component * Tweak docs/controls * Rename ThemeProvider -> PenumbraUIProvider * Fix issue with extraneous DOM attributes * Make onClose optional * Add the PenumbraUIProvider to minifront * Export the Status interface * Create the syncing modal * Render the syncing modal; remove the duplicate MotionConfig * Fix Colors story * Tweak comment * Add missing prop * Rename SyncingModal -> SyncingDialog * Fix typings issue; rename import * Fix styled-components problem * Remove unnecessary import * Add comment * Add typings for images * Disable SyncingDialog for now * `<Card />` component (#1606) * Create initial Card component * Tweak story * Tweak styles/story * Write tests * Compress bg image
Creates a simple
<Card />
component, which will likely grow in complexity over time as we start using it in various screens.Demo here