Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<Card /> component #1606

Merged
merged 5 commits into from
Aug 1, 2024
Merged

<Card /> component #1606

merged 5 commits into from
Aug 1, 2024

Conversation

jessepinho
Copy link
Contributor

@jessepinho jessepinho commented Jul 31, 2024

Creates a simple <Card /> component, which will likely grow in complexity over time as we start using it in various screens.

Demo here

Copy link

changeset-bot bot commented Jul 31, 2024

⚠️ No Changeset found

Latest commit: 1cfad00

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jul 31, 2024

Visit the preview URL for this PR (updated for commit 1cfad00):

https://penumbra-ui-preview--pr1606-jessepinho-card-2-rz1wxq2j.web.app

(expires Thu, 08 Aug 2024 16:45:16 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 709d729610ef7a6369b23f1cb2b820a60cc685b1

@jessepinho jessepinho changed the base branch from main to jessepinho/card July 31, 2024 18:57
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jessepinho jessepinho marked this pull request as ready for review July 31, 2024 21:02
@jessepinho jessepinho changed the title WIP: <Card /> component <Card /> component Jul 31, 2024
@jessepinho jessepinho requested a review from a team July 31, 2024 21:46
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a wish: can this image be compressed a little? When I first entered the Card's storybook, it was empty for like 5 seconds until the image loaded

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes — good call. It was 8MB! I've compressed it to a 100kb JPEG.

@jessepinho jessepinho merged commit 64894b2 into jessepinho/card Aug 1, 2024
8 checks passed
@jessepinho jessepinho deleted the jessepinho/card-2 branch August 1, 2024 16:59
jessepinho added a commit that referenced this pull request Aug 1, 2024
…ra UI component (#1584)

* Add blurs and base colors to theme

* Add Xxl text size

* Tweak blur radius; add z indexes

* Create initial Dialog component

* Allow for button groups to always be a column

* Build out more of the Dialog component

* Tweak docs/controls

* Rename ThemeProvider -> PenumbraUIProvider

* Fix issue with extraneous DOM attributes

* Make onClose optional

* Add the PenumbraUIProvider to minifront

* Export the Status interface

* Create the syncing modal

* Render the syncing modal; remove the duplicate MotionConfig

* Fix Colors story

* Tweak comment

* Add missing prop

* Rename SyncingModal -> SyncingDialog

* Fix typings issue; rename import

* Fix styled-components problem

* Remove unnecessary import

* Add comment

* Add typings for images

* Disable SyncingDialog for now

* `<Card />` component (#1606)

* Create initial Card component

* Tweak story

* Tweak styles/story

* Write tests

* Compress bg image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants