1604 hastokenbalance should ignore randomizer and use index only

.changeset/pretty-poets-rescue.md

@@ -0,0 +1,7 @@
+---
+'@penumbra-zone/services': minor
+'@penumbra-zone/storage': minor
+'@penumbra-zone/types': minor
+---
+
+fix source randomizer

apps/minifront/src/state/helpers.ts

@@ -54,6 +54,11 @@ export const planBuildBroadcast = async (
   const rpcMethod = options?.skipAuth ? viewClient.witnessAndBuild : viewClient.authorizeAndBuild;
 
   try {
+    // TODO: Temp fix to not compare randomizer. Can delete after v11.10 is released.
+    if (req.source) {
+      req.source.randomizer = new Uint8Array();
+    }
+
     const transactionPlan = await plan(req);
 
     const transaction = await build({ transactionPlan }, rpcMethod, status =>

packages/services/src/view-service/fees.ts

@@ -117,7 +117,7 @@ export const getAssetFromGasPriceTable = async (
   // If a specific asset ID is provided, extracted from the transaction request, check its balance is
   // positive and GasPrices for that asset exist.
   if (assetId) {
-    const balance = await indexedDb.hasTokenBalance(request.source, assetId);
+    const balance = await indexedDb.hasTokenBalance(request.source.account, assetId);
     // This check ensures that the alternative fee token is a valid fee token, for example, TestUSD is not.
     const isInGasTable = altGasPrices.find(gp => gp.assetId?.equals(assetId));
     if (balance && isInGasTable) {
@@ -129,7 +129,7 @@ export const getAssetFromGasPriceTable = async (
   // GasPrices table as a fallback case.
   for (const gasPrice of altGasPrices) {
     if (gasPrice.assetId) {
-      const balance = await indexedDb.hasTokenBalance(request.source, gasPrice.assetId);
+      const balance = await indexedDb.hasTokenBalance(request.source.account, gasPrice.assetId);
       if (balance) {
         return gasPrice.assetId;
       }

packages/services/src/view-service/transaction-planner/index.ts

@@ -15,7 +15,10 @@ export const transactionPlanner: Impl['transactionPlanner'] = async (req, ctx) =
   const { indexedDb } = await services.getWalletServices();
 
   // Query IndexedDB directly to check for the existence of staking token
-  const nativeToken = await indexedDb.hasTokenBalance(req.source!, indexedDb.stakingTokenAssetId);
+  const nativeToken = await indexedDb.hasTokenBalance(
+    req.source!.account,
+    indexedDb.stakingTokenAssetId,
+  );
 
   // Check if we should use the native token or extract an alternate gas fee token.
   // Special cased for swap claims as gas fee needs to match the claimFee on the corresponding swap.

packages/storage/src/indexed-db/index.ts

@@ -869,7 +869,7 @@ export class IndexedDb implements IndexedDbInterface {
     };
   }
 
-  async hasTokenBalance(addressIndex: AddressIndex, assetId: AssetId): Promise<boolean> {
+  async hasTokenBalance(accountIndex: number, assetId: AssetId): Promise<boolean> {
     const spendableNotes = await this.db.getAllFromIndex(
       'SPENDABLE_NOTES',
       'assetId',
@@ -878,10 +878,12 @@ export class IndexedDb implements IndexedDbInterface {
 
     return spendableNotes.some(note => {
       const spendableNote = SpendableNoteRecord.fromJson(note);
+
+      // randomizer should be ignored
       return (
         spendableNote.heightSpent === 0n &&
         !isZero(getAmountFromRecord(spendableNote)) &&
-        spendableNote.addressIndex?.equals(addressIndex)
+        spendableNote.addressIndex?.account === accountIndex
       );
     });
   }

packages/types/src/indexed-db.ts

@@ -150,7 +150,7 @@ export interface IndexedDbInterface {
     auctionId: AuctionId,
   ): Promise<{ input: Value; output: Value } | undefined>;
 
-  hasTokenBalance(addressIndex: AddressIndex, assetId: AssetId): Promise<boolean>;
+  hasTokenBalance(addressIndex: number, assetId: AssetId): Promise<boolean>;
 }
 
 export interface PenumbraDb extends DBSchema {