Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create <Pill />/<ValueViewComponent /> components #1526

Merged
merged 16 commits into from
Jul 26, 2024
Merged

Create <Pill />/<ValueViewComponent /> components #1526

merged 16 commits into from
Jul 26, 2024

Conversation

jessepinho
Copy link
Contributor

@jessepinho jessepinho commented Jul 22, 2024 •
edited
Loading

In this PR

  • Create a <Pill /> component
  • Create a <ValueViewComponent /> component
  • Create a <ConditionalWrap /> utility component for conditionally wrapping markup in other markup

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 22, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 03507ae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 22, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 03507ae):

https://penumbra-ui-preview--pr1526-jessepinho-pill-vj0bxyyq.web.app

(expires Thu, 01 Aug 2024 19:19:44 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 709d729610ef7a6369b23f1cb2b820a60cc685b1

@jessepinho jessepinho force-pushed the jessepinho/pill branch 4 times, most recently from 13a8027 to 91e0c1f Compare July 23, 2024 03:57
@jessepinho jessepinho changed the title WIP: Create a Pill component WIP: Create <Pill />/<ValueViewComponent /> components Jul 23, 2024
jessepinho
jessepinho commented Jul 23, 2024
View reviewed changes
packages/ui/src/Pill/index.stories.tsx Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://penumbra-ui-preview--pr1526-jessepinho-pill-vj0bxyyq.web.app/?path=/docs/ui-library-pill--docs

jessepinho
jessepinho commented Jul 23, 2024
View reviewed changes
packages/ui/src/ValueViewComponent/AssetIcon/DelegationTokenIcon.tsx Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is copied over almost verbatim from here. It just has some tweaks to how it uses the size prop, and it now uses styled-components.

jessepinho
jessepinho commented Jul 23, 2024
View reviewed changes
packages/ui/src/ValueViewComponent/AssetIcon/UnbondingTokenIcon.tsx Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like DelegationTokenIcon, this file is copied over almost verbatim from here. It just has some tweaks to how it uses the size prop, and it now uses styled-components.

jessepinho
jessepinho commented Jul 23, 2024
View reviewed changes
packages/ui/src/ValueViewComponent/AssetIcon/index.tsx Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like DelegationTokenIcon, this file is copied over almost verbatim from here. It just has some tweaks to how it uses the size prop, and it now uses styled-components.

jessepinho
jessepinho commented Jul 23, 2024
View reviewed changes
packages/ui/src/ValueViewComponent/AssetIcon/Identicon/index.tsx Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copied almost verbatim from here

jessepinho
jessepinho commented Jul 23, 2024
View reviewed changes
packages/ui/src/ValueViewComponent/AssetIcon/Identicon/generate.ts Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copied verbatim from here

jessepinho
jessepinho commented Jul 23, 2024
View reviewed changes
packages/ui/src/ValueViewComponent/index.stories.tsx Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://penumbra-ui-preview--pr1526-jessepinho-pill-vj0bxyyq.web.app/?path=/docs/ui-library-valueviewcomponent--docs

@jessepinho jessepinho marked this pull request as ready for review July 23, 2024 04:05
@jessepinho jessepinho changed the title WIP: Create <Pill />/<ValueViewComponent /> components Create <Pill />/<ValueViewComponent /> components Jul 23, 2024
@jessepinho jessepinho requested a review from a team July 23, 2024 04:05
@jessepinho
Copy link
Contributor Author

sorry about the changes y'all — got some tweaks in Figma that I had to update here

VanishMax
VanishMax requested changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@VanishMax VanishMax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only one small bug 🐛

packages/ui/src/ValueViewComponent/sampleValueViews.ts Outdated Show resolved Hide resolved
packages/ui/src/ConditionalWrap.tsx Outdated Show resolved Hide resolved
VanishMax
VanishMax approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@VanishMax VanishMax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jessepinho jessepinho merged commit 9da630e into main Jul 26, 2024
8 checks passed
@jessepinho jessepinho deleted the jessepinho/pill branch July 26, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VanishMax VanishMax VanishMax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jessepinho @VanishMax