Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enable react hooks lint #1510

Merged
merged 9 commits into from
Jul 22, 2024
Merged

re-enable react hooks lint #1510

merged 9 commits into from
Jul 22, 2024

Conversation

turbocrime
Copy link
Contributor

and fix

Copy link

changeset-bot bot commented Jul 18, 2024

🦋 Changeset detected

Latest commit: a12d4b5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@penumbra-zone/zquery Patch
minifront Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jul 18, 2024

Visit the preview URL for this PR (updated for commit b653ab9):

https://penumbra-ui-preview--pr1510-turbocrime-fix-hooks-769k3any.web.app

(expires Thu, 25 Jul 2024 19:03:51 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 709d729610ef7a6369b23f1cb2b820a60cc685b1

@turbocrime turbocrime force-pushed the turbocrime/fix-hooks branch from 9686e0e to b653ab9 Compare July 18, 2024 19:02
@turbocrime turbocrime force-pushed the turbocrime/fix-hooks branch from b653ab9 to 42fb94e Compare July 22, 2024 19:51
Copy link
Contributor

@jessepinho jessepinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small comments, then ship it!

@turbocrime turbocrime merged commit e0f4258 into main Jul 22, 2024
6 checks passed
@turbocrime turbocrime deleted the turbocrime/fix-hooks branch July 22, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants