Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix format ci #1504

Merged
merged 2 commits into from
Jul 18, 2024
Merged

fix format ci #1504

merged 2 commits into from
Jul 18, 2024

Conversation

turbocrime
Copy link
Contributor

@turbocrime turbocrime commented Jul 17, 2024

eslint reconfig included introduction of pretty-quick for a small speed benefit

doing some local work, a prettier minor bump changed some specific parenthesis formatting around nullish coalescing operators within ternary conditional statements, and it broke pretty-quick, which assumed an unedited file would not need reformatting

this just reverts to using prettier for all formatting and format-checking, since the speed benefit was small

Copy link

changeset-bot bot commented Jul 17, 2024

⚠️ No Changeset found

Latest commit: fdc2d6d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jul 17, 2024

Visit the preview URL for this PR (updated for commit fdc2d6d):

https://penumbra-ui-preview--pr1504-turbocrime-prevent-p-awqd6ood.web.app

(expires Thu, 25 Jul 2024 18:25:01 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 709d729610ef7a6369b23f1cb2b820a60cc685b1

@turbocrime turbocrime requested a review from a team July 18, 2024 17:40
@turbocrime turbocrime changed the title prevent format ci from breaking fix format ci Jul 18, 2024
@turbocrime turbocrime mentioned this pull request Jul 18, 2024
@turbocrime turbocrime force-pushed the turbocrime/prevent-prettier-breaking branch from e19bbca to 2ca681d Compare July 18, 2024 17:49
Copy link
Contributor

@TalDerei TalDerei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to merge after green ci

@turbocrime turbocrime self-assigned this Jul 18, 2024
@turbocrime turbocrime merged commit 11e9b7f into main Jul 18, 2024
8 checks passed
@turbocrime turbocrime deleted the turbocrime/prevent-prettier-breaking branch July 18, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants