Create Storybook stories for Penumbra colors #1500
Conversation
|
jessepinho
force-pushed
the
jessepinho/colors
branch
from
21b49db to
ae32dbb
Compare
jessepinho
changed the base branch from
jessepinho/sc-theme
to
jessepinho/new-components-1
|
Visit the preview URL for this PR (updated for commit ae32dbb): https://penumbra-ui-preview--pr1500-jessepinho-colors-xw8bzgdf.web.app (expires Wed, 24 Jul 2024 21:36:54 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 709d729610ef7a6369b23f1cb2b820a60cc685b1 |
| @@ -0,0 +1,108 @@ | |||
| import type { Meta, StoryObj } from '@storybook/react'; | |||
| import { Grid } from './Grid'; | |||
| import { Technical } from './Typography'; | |||
There was a problem hiding this comment.
question: are these changes coming from #1489? It confused me since Technical and other components were not reviewed yet but the questions are mostly about them, not the color stories 😅
It's just that even if we merge this PR now, these changes will need to be reviewed once again with other changes
There was a problem hiding this comment.
@VanishMax ah, yes, but I haven't made that PR ready for review yet (oops). My plan was to wait until they're all approved, then merge them into each other and finally into main. If you give this the 👍🏻 , I'll wait to merge it until #1489 is approved and merged.
There was a problem hiding this comment.
Just marked #1489 ready for review as well
* Build new components * Fix quotation marks * Move colors to other PR * Delete button-related components for now * Split out typography components * Add docs for Detail * Document typography file * Fix import * Fix a few issues with how Storybook displays the Grid story * Revert "Split out typography components" This reverts commit 7740d3f. * Create a Text component * Create Storybook stories for Penumbra colors (#1500)
* Build out styled-components theme * Add Iosevka Term; add quotation marks * Add comment * Add comment * Build out new UI components (#1489) * Build new components * Fix quotation marks * Move colors to other PR * Delete button-related components for now * Split out typography components * Add docs for Detail * Document typography file * Fix import * Fix a few issues with how Storybook displays the Grid story * Revert "Split out typography components" This reverts commit 7740d3f. * Create a Text component * Create Storybook stories for Penumbra colors (#1500) * Fix imports
Creates this page in Storybook