Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable the dex and ibc in minifront #1491

Closed
wants to merge 6 commits into from
Closed

disable the dex and ibc in minifront #1491

wants to merge 6 commits into from

Conversation

TalDerei
Copy link
Contributor

@TalDerei TalDerei commented Jul 17, 2024

references #1454

cc @hdevalence the warning messages can probably be improved.

Screenshot 2024-07-17 at 12 05 01 AM

@TalDerei TalDerei self-assigned this Jul 17, 2024
Copy link

changeset-bot bot commented Jul 17, 2024

⚠️ No Changeset found

Latest commit: 1ba7f31

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jul 17, 2024

Visit the preview URL for this PR (updated for commit 1ba7f31):

https://penumbra-ui-preview--pr1491-disable-dex-ibc-qo1kfk3v.web.app

(expires Wed, 24 Jul 2024 09:39:33 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 709d729610ef7a6369b23f1cb2b820a60cc685b1

@TalDerei TalDerei requested a review from a team July 17, 2024 09:32
@grod220
Copy link
Contributor

grod220 commented Jul 18, 2024

Instead of a toast that shows up after they attempt an action, how about we just have a little banner at the top of the page with a message? Sort of like the red:
662957b844850e404d74288a_apple-website-notification-bar-1160x467

@TalDerei
Copy link
Contributor Author

Instead of a toast that shows up after they attempt an action, how about we just have a little banner at the top of the page with a message?

that's a good idea. I think we should also still display a toast with the friendlier error message, effectively disabling the functionality in the UI. Otherwise, the alternative is allowing transaction planning to occur and letting the transactions fail.

the only thing I was worried about is the banner possibly displaying when it shouldn't, given our weird sync behaviors?

@Valentine1898
Copy link
Contributor

the only thing I was worried about is the banner possibly displaying when it shouldn't, given our weird sync behaviors?

I think this can be avoided if we show banner only when AppParameters are available and only if dexEnabled is false

@TalDerei TalDerei closed this Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants