-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable the dex and ibc in minifront #1491
Conversation
|
Visit the preview URL for this PR (updated for commit 1ba7f31): https://penumbra-ui-preview--pr1491-disable-dex-ibc-qo1kfk3v.web.app (expires Wed, 24 Jul 2024 09:39:33 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 709d729610ef7a6369b23f1cb2b820a60cc685b1 |
that's a good idea. I think we should also still display a toast with the friendlier error message, effectively disabling the functionality in the UI. Otherwise, the alternative is allowing transaction planning to occur and letting the transactions fail. the only thing I was worried about is the banner possibly displaying when it shouldn't, given our weird sync behaviors? |
I think this can be avoided if we show banner only when |
references #1454
cc @hdevalence the warning messages can probably be improved.