-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: display block height in tx detail #1470
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: it would be nice if the style matched (font style and color)
i wonder if we should make a practice of consistently displaying 'epoch' along with block height, maybe with a short notation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed, we should keep the style consistent. I'd also remove the 'in', and maybe you can experiment with encapsulating the block height in a small pill in the top right, similar to the memo field?
693a419
to
03d7bfd
Compare
@TalDerei addressed your feedback and used the pill. |
fixes #1359