Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display block height in tx detail #1470

Merged
merged 4 commits into from
Jul 17, 2024

Conversation

vacekj
Copy link
Member

@vacekj vacekj commented Jul 11, 2024

fixes #1359

image

Copy link

changeset-bot bot commented Jul 11, 2024

⚠️ No Changeset found

Latest commit: 789b1e2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@turbocrime turbocrime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: it would be nice if the style matched (font style and color)

@turbocrime
Copy link
Contributor

i wonder if we should make a practice of consistently displaying 'epoch' along with block height, maybe with a short notation.

Copy link
Contributor

@TalDerei TalDerei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, we should keep the style consistent. I'd also remove the 'in', and maybe you can experiment with encapsulating the block height in a small pill in the top right, similar to the memo field?

@vacekj vacekj force-pushed the 1359-add-block-height-to-tx-details branch from 693a419 to 03d7bfd Compare July 16, 2024 14:00
@vacekj vacekj requested a review from TalDerei July 16, 2024 14:34
@vacekj
Copy link
Member Author

vacekj commented Jul 16, 2024

@TalDerei addressed your feedback and used the pill.

@vacekj vacekj merged commit dc53cf9 into main Jul 17, 2024
6 checks passed
@vacekj vacekj deleted the 1359-add-block-height-to-tx-details branch July 17, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add block height to tx details
3 participants