Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(minifront): #1225: reverse swap button #1457

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Conversation

VanishMax
Copy link
Contributor

Closes #1225

Made the arrow button clickable. Reverse actions preserve the account index selected for the assetIn

@VanishMax VanishMax requested a review from a team July 9, 2024 11:51
@VanishMax VanishMax self-assigned this Jul 9, 2024
Copy link
Contributor

@TalDerei TalDerei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice use of the getters and internal state tracking!

maybe a double arrow would be more idiomatic here?

@VanishMax
Copy link
Contributor Author

@TalDerei I tried using double-arrow icon and it confused me, it just doesn't fit in the swap page designs for now idk. Probably would be good for a new issue

@VanishMax VanishMax merged commit 4914063 into main Jul 10, 2024
6 checks passed
@VanishMax VanishMax deleted the feat/#1225-reverse-swap branch July 10, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking the arrow in the trade widget should reverse assets
2 participants