fix: #657: stop truncating metadata symbols #1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This affects some other ui components It is also necessary to bump indexed-db version, otherwise metadata that is already stored in the DB will not be updated |
|
@Valentine1898 thanks for noting the issues. Fixed multiple places with incorrect truncation + improved the Dialog component for mobile screens |
Valentine1898
approved these changes
Jul 9, 2024
| export const IDB_VERSION = 44; | ||
| export const IDB_VERSION = 45; |
There was a problem hiding this comment.
To clarify, this will cause mainnet users must sync again after updating the extension in chrome store. Should we already consider indexed-db migrations without data loss?
There was a problem hiding this comment.
Think we are ok for now, syncing is very fast with the low block height at the moment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #657
Removed metadata symbol trimming from wasm and added max-width to the
ValueComponentwith the native tooltip, so users can always access the asset symbol.