fix unknownAssetId bugs #1110
Merged
fix unknownAssetId bugs #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Valentine1898
force-pushed
the
1108-unknown-asset-selected-bug
branch
from
6d92f29 to
9f05366
Compare
Valentine1898
commented
May 14, 2024
Comment on lines
-155
to
-156
| if (asset.balanceView?.valueView.case !== 'knownAssetId') | ||
| throw new Error('unknown asset selected'); |
There was a problem hiding this comment.
We filter out unknown assets for ibc and swaps, but I believe there is no reason to disallow sending unknown assets
|
Not relevant to this PR, but maybe we don't need to show zero balances? |
grod220
approved these changes
May 14, 2024
Comment on lines
36
to
55
| const renderPill = (formattedAmount: string, symbol: string, metadata?: Metadata) => ( | ||
| <Pill variant={variant === 'default' ? 'default' : 'dashed'}> | ||
| <div className='flex min-w-0 items-center gap-1'> | ||
| {showIcon && ( | ||
| <div className='-ml-2 mr-1 flex shrink-0 items-center justify-center rounded-full'> | ||
| <AssetIcon metadata={metadata} size={size === 'default' ? 'sm' : 'xs'} /> | ||
| </div> | ||
| )} | ||
| {showValue && ( | ||
| <span className={cn('-mb-0.5 text-nowrap leading-[15px]', size === 'sm' && 'text-xs')}> | ||
| {variant === 'equivalent' && <>~ </>} | ||
| {formattedAmount} | ||
| </span> | ||
| )} | ||
| {showDenom && ( | ||
| <span className='truncate font-mono text-xs text-muted-foreground'>{symbol}</span> | ||
| )} | ||
| </div> | ||
| </Pill> | ||
| ); |
There was a problem hiding this comment.
Can you make this a separate component instead of an inline function?
TalDerei
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1107 & close #1108
1. Dashboard
Before:
After:
2. Send
Before:
After:
3. Tx page
Before:
After: